Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 788883004: Not counting nested loops as time spent in a task (Closed)

Created:
6 years ago by vadimt
Modified:
6 years ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Not counting nested loops as time spent in a task. While in a nested loop, Chrome is not blocked, keeps updating the client area and is responding to user actions. Subtracting the time in nested loops from the task in which it happens, so that we don't diagnose this task as a source of jank. BUG=401560, 440919 Committed: https://crrev.com/86708713f8a40a9155d56310b9b9a63515f58846 Cr-Commit-Position: refs/heads/master@{#308218}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M ui/gfx/win/hwnd_util.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_win.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vadimt
sky@, please review.
6 years ago (2014-12-12 22:19:35 UTC) #2
sky
LGTM
6 years ago (2014-12-13 00:17:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788883004/1
6 years ago (2014-12-13 00:22:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-13 01:52:23 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-13 01:53:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/86708713f8a40a9155d56310b9b9a63515f58846
Cr-Commit-Position: refs/heads/master@{#308218}

Powered by Google App Engine
This is Rietveld 408576698