Issue 7888005: Revert valgrind suppression for bug 89300

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7888005: Revert valgrind suppression for bug 89300 (Closed)

Created:
9 years, 3 months ago by willchan no longer on Chromium

Modified:
9 years, 3 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Revert valgrind suppression for bug 89300 IOThread doesn't register URLRequestContextGetters anymore. Stacktrace is out of date. BUG=89300 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100880

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -9 lines)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+0 lines, -9 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

9 years, 3 months ago (2011-09-13 08:28:53 UTC) #2

LGTM
On Sep 13, 2011 9:24 AM, <willchan@chromium.org> wrote:
> Reviewers: jochen,
>
> Message:
> TBR
>
> Description:
> Revert valgrind suppression for bug 89300
>
> IOThread doesn't register URLRequestContextGetters anymore. Stacktrace is
> out of
> date.
>
> BUG=89300
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/7888005/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
> M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
>
bae2b1301ab1096ebfdadd31adbb0cc6d4facff6..b3bccd728bad26d1349c53ed0ef84d24a09606b4

> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -4250,15 +4250,6 @@
>
>
fun:_ZN3IPC12ChannelProxyC1ERKNS_13ChannelHandleENS_7Channel4ModeEPNS4_8ListenerEPN4base16MessageLoopProxyE
> }
> {
> - bug_89300
> - Memcheck:Leak
> - fun:_Znw*
> - ...
> -
>
fun:_ZN8IOThread31RegisterURLRequestContextGetterEP29ChromeURLRequestContextGetter
> - fun:_ZN29ChromeURLRequestContextGetter20GetURLRequestContextEv
> -
>
fun:_ZL23AddDataSourceOnIOThread13scoped_refptrIN3net23URLRequestContextGetterEES_IN20ChromeURLDataManager10DataSourceEE
> -}
> -{
> bug_89304
> Memcheck:Leak
> fun:_Znw*
>
>

Expand Messages | Collapse Messages