Issue 788773006: Remove extension check from CustomElementRegistry.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 788773006: Remove extension check from CustomElementRegistry. (Closed)

Created:
5 years, 11 months ago by esprehn

Modified:
5 years, 11 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove extension check from CustomElementRegistry. We only have the main world, we don't need this check. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4d8b1088a0bf15ce2bd4cc7e7356950c0fc7ad7a

Created: 5 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -16 lines)			Patch
M	sky/engine/bindings/core/v8/CustomElementConstructorBuilder.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/bindings/core/v8/CustomElementConstructorBuilder.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	sky/engine/core/dom/custom/CustomElementException.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/dom/custom/CustomElementException.cpp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	sky/engine/core/dom/custom/CustomElementRegistry.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download

Total messages: 3 (1 generated)

esprehn

5 years, 11 months ago (2015-01-14 00:01:54 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4d8b1088a0bf15ce2bd4cc7e7356950c0fc7ad7a (presubmit successful).