Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 788773003: Update tests in preparation for shipping classes. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Update tests in preparation for shipping classes. R=arv@chromium.org BUG=v8:3330 LOG=N

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M test/mjsunit/regress/regress-parse-object-literal.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/mjsunit/strict-mode.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/preparser/strict-function-statement.pyt View 1 chunk +4 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +12 lines, -8 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
Dmitry Lomov (no reviews)
PTAL
6 years ago (2014-12-11 14:10:52 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/788773003/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/788773003/diff/1/test/test262/test262.status#newcode40 test/test262/test262.status:40: 'Sbp_A1_T1': [PASS, FAIL_OK], Do you know if this ...
6 years ago (2014-12-11 15:16:22 UTC) #2
Dmitry Lomov (no reviews)
https://codereview.chromium.org/788773003/diff/1/test/test262/test262.status File test/test262/test262.status (right): https://codereview.chromium.org/788773003/diff/1/test/test262/test262.status#newcode40 test/test262/test262.status:40: 'Sbp_A1_T1': [PASS, FAIL_OK], On 2014/12/11 15:16:22, arv wrote: > ...
6 years ago (2014-12-11 15:26:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788773003/1
6 years ago (2014-12-11 15:26:55 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-11 15:54:02 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698