Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Unified Diff: testing/android/java/src/org/chromium/native_test/ChromiumNativeTestInstrumentationTestRunner.java

Issue 788753002: [Android] Implement gtest and local in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix findbugs + move log parsing up to GtestTestInstance Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/android/unit_tests_apk/AndroidManifest.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/android/java/src/org/chromium/native_test/ChromiumNativeTestInstrumentationTestRunner.java
diff --git a/testing/android/java/src/org/chromium/native_test/ChromiumNativeTestInstrumentationTestRunner.java b/testing/android/java/src/org/chromium/native_test/ChromiumNativeTestInstrumentationTestRunner.java
index 5e8d8e5b72aca064748c87f49fb98b2c3c88387a..8fe5d6ca99485963c351a4e2231881a876db4758 100644
--- a/testing/android/java/src/org/chromium/native_test/ChromiumNativeTestInstrumentationTestRunner.java
+++ b/testing/android/java/src/org/chromium/native_test/ChromiumNativeTestInstrumentationTestRunner.java
@@ -114,7 +114,6 @@ public class ChromiumNativeTestInstrumentationTestRunner extends Instrumentation
r = new BufferedReader(
new InputStreamReader(new BufferedInputStream(new FileInputStream(fifo))));
- StringBuilder resultsStr = new StringBuilder();
for (String l = r.readLine(); l != null && !l.equals("<<ScopedMainEntryLogger");
l = r.readLine()) {
Matcher m = RE_TEST_OUTPUT.matcher(l);
@@ -127,11 +126,9 @@ public class ChromiumNativeTestInstrumentationTestRunner extends Instrumentation
results.put(m.group(2), TestResult.PASSED);
}
}
- resultsStr.append(l);
- resultsStr.append("\n");
+ mLogBundle.putString(Instrumentation.REPORT_KEY_STREAMRESULT, l + "\n");
+ sendStatus(0, mLogBundle);
}
- mLogBundle.putString(Instrumentation.REPORT_KEY_STREAMRESULT, resultsStr.toString());
- sendStatus(0, mLogBundle);
} catch (InterruptedException e) {
Log.e(TAG, "Interrupted while waiting for FIFO file creation: " + e.toString());
} catch (FileNotFoundException e) {
« no previous file with comments | « chrome/test/android/unit_tests_apk/AndroidManifest.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698