build/android/pylib/base/environment_factory.py - Issue 788753002: [Android] Implement gtest and local in platform mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/base/environment_factory.py

Issue 788753002: [Android] Implement gtest and local in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: exe and tool support, and bug fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/pylib/base/environment_factory.py

diff --git a/build/android/pylib/base/environment_factory.py b/build/android/pylib/base/environment_factory.py

index c96d19920f7802c5e1a5d8cff9ae6ecb941457dd..5d940a86caadbff55c39fae61e611ac111692102 100644

--- a/build/android/pylib/base/environment_factory.py

+++ b/build/android/pylib/base/environment_factory.py

@@ -2,10 +2,16 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

+from pylib import constants

+from pylib.local.device import local_device_environment

-def CreateEnvironment(_args, error_func):

- # TODO(jbudorick) Add local device environment.

- # TODO(jbudorick) Add local machine environment.

- error_func('No environments currently supported.')

+def CreateEnvironment(args, error_func):

+ if args.environment == 'local':

+ if args.command not in constants.LOCAL_MACHINE_TESTS:

+ return local_device_environment.LocalDeviceEnvironment(args, error_func)

+ # TODO(jbudorick) Add local machine environment.

+ error_func('Unable to create %s environment.' % args.environment)

« no previous file with comments | « build/android/PRESUBMIT.py ('k') | build/android/pylib/base/test_collection.py » ('j') | build/android/pylib/gtest/gtest_test_instance.py » ('J')