build/android/pylib/base/test_instance_factory.py - Issue 788753002: [Android] Implement gtest and local in platform mode.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/pylib/base/test_instance_factory.py

Issue 788753002: [Android] Implement gtest and local in platform mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix findbugs + move log parsing up to GtestTestInstance Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « build/android/pylib/base/test_collection.py ('k') | build/android/pylib/base/test_run_factory.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2014 The Chromium Authors. All rights reserved.	1 # Copyright 2014 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 from pylib import constants	5 from pylib import constants

6 from pylib.gtest import gtest_test_instance	6 from pylib.gtest import gtest_test_instance

7 from pylib.utils import isolator	7 from pylib.utils import isolator

8 from pylib.uirobot import uirobot_test_instance	8 from pylib.uirobot import uirobot_test_instance

9	9

10	10

11	11

12 def CreateTestInstance(args, error_func):	12 def CreateTestInstance(args, error_func):

13	13

14 if args.command == 'gtest':	14 if args.command == 'gtest':

15 return gtest_test_instance.GtestTestInstance(	15 return gtest_test_instance.GtestTestInstance(

16 args, isolator.Isolator(constants.ISOLATE_DEPS_DIR))	16 args, isolator.Isolator(constants.ISOLATE_DEPS_DIR), error_func)

17 if args.command == 'uirobot':	17 if args.command == 'uirobot':

18 return uirobot_test_instance.UirobotTestInstance(args)	18 return uirobot_test_instance.UirobotTestInstance(args)

19 # TODO(jbudorick) Add instrumentation test instance.	19 # TODO(jbudorick) Add instrumentation test instance.

20	20

21 error_func('Unable to create %s test instance.' % args.command)	21 error_func('Unable to create %s test instance.' % args.command)

OLD	NEW