sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart - Issue 78873007: Support type argument substitution on unnamed mixin applications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

Issue 78873007: Support type argument substitution on unnamed mixin applications. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart ('k') | sdk/lib/_internal/lib/js_mirrors.dart » ('j') | sdk/lib/_internal/lib/js_mirrors.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

index 373b65dd369bdeb11dd39c4a24a414d33096fe64..4846cb613af23cb235bec04ffce8b6b867b2b958 100644

--- a/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart

@@ -60,10 +60,10 @@ String getReflectionDataParser(String classesCollector, Namer namer) {

var element = descriptor[property];

var firstChar = property.substring(0, 1);

var previousProperty;

- if (firstChar === "+") {

- mangledGlobalNames[previousProperty] = property.substring(1);

- if (descriptor[property] == 1) ''' // Break long line.

-'''descriptor[previousProperty].$reflectableField = 1;

+ if (firstChar === "+" || firstChar === "-") {

+ if (firstChar === "+") ${/* Break long line.

+*/""}mangledGlobalNames[previousProperty] = property.substring(1);

Johnni Winther 2013/11/25 07:19:20 Indent to align `mangledGlobalNames...` under `fir

zarah 2013/12/19 10:53:34 Done.

+ if (element == 1) descriptor[previousProperty].$reflectableField = 1;

Johnni Winther 2013/11/25 07:19:20 Indent to align with `if (element)...` below.

zarah 2013/12/19 10:53:34 Done.

if (element && element.length) ''' // Break long line.

'''init.typeInformation[previousProperty] = element;

} else if (firstChar === "@") {