Issue 78873006: Embed trigonometric lookup table.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78873006: Embed trigonometric lookup table. (Closed)

Created:
7 years, 1 month ago by Yang

Modified:
7 years, 1 month ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Embed trigonometric lookup table. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17965

Patch Set 2 : tiny fixes #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -194 lines)			Patch
M	src/bootstrapper.cc	View		3 chunks	+37 lines, -2 lines	0 comments	Download
M	src/math.js	View		5 chunks	+70 lines, -112 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	src/runtime.cc	View	1	1 chunk	+0 lines, -29 lines	0 comments	Download
A +	src/trig-table.h	View		1 chunk	+18 lines, -17 lines	2 comments	Download
A +	tools/generate-trig-table.py	View		2 chunks	+46 lines, -33 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1	5 chunks	+23 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM with nits. https://codereview.chromium.org/78873006/diff/40001/src/trig-table.h File src/trig-table.h (right): https://codereview.chromium.org/78873006/diff/40001/src/trig-table.h#newcode36 src/trig-table.h:36: public: Let's make all the members ...

7 years, 1 month ago (2013-11-21 12:25:45 UTC) #2

Yang

7 years, 1 month ago (2013-11-21 12:57:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17965 (presubmit successful).

Expand Messages | Collapse Messages

Issue 78873006: Embed trigonometric lookup table. (Closed)

Description

Patch Set 1 #

Patch Set 2 : tiny fixes #

Messages