Subzero: Disable stats and timers under the MINIMAL build.

Subzero: Disable stats and timers under the MINIMAL build.

Specifically, don't bother to collect "-timing" and "-szstats" information since they anyway don't get printed out under the MINIMAL build.  This is done by using the ALLOW_DUMP flag to guard whether code and timing stats are collected.  This ends up reducing the native translator size by about 3%.  ALLOW_DUMP is used as the guard since it already guards the output of the collected data - no sense collecting the data if it can never be printed out.

To minimize the number of ALLOW_DUMP tests, we push the tests into the timing/stats class methods.

BUG= none
R=jvoung@chromium.org, kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=1c44d81950c17d9dac4d5d8e5b65085a753286a9

[Jim Stichnoth, 2014-12-08 20:22:36]

stichnot@chromium.org changed reviewers:
+ jvoung@chromium.org, kschimpf@google.com

[Karl, 2014-12-08 21:08:01]

When I first read the description of this CL, I did not understand what was
being removed. It appears from the review that you aren't removing the timers,
but just making the timing routines do nothing. Could this be made clearer in
the description?

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp
File src/IceTimerTree.cpp (right):

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode51
src/IceTimerTree.cpp:51: void TimerStack::push(TimerIdT ID) {
Suggest adding quick cutoff here as well. That way, we don't have to count on
the callers removing this.

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode68
src/IceTimerTree.cpp:68: void TimerStack::pop(TimerIdT ID) {
Same here.

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode83
src/IceTimerTree.cpp:83: void TimerStack::update(bool UpdateCounts) {
Same here.

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode117
src/IceTimerTree.cpp:117: void TimerStack::reset() {
Same here.

[Jim Stichnoth, 2014-12-08 21:33:57]

Description updated and hopefully clarified.

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp
File src/IceTimerTree.cpp (right):

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode51
src/IceTimerTree.cpp:51: void TimerStack::push(TimerIdT ID) {
On 2014/12/08 21:08:01, Karl wrote:
> Suggest adding quick cutoff here as well. That way, we don't have to count on
> the callers removing this.

Done.

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode68
src/IceTimerTree.cpp:68: void TimerStack::pop(TimerIdT ID) {
On 2014/12/08 21:08:01, Karl wrote:
> Same here.

Done.

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode83
src/IceTimerTree.cpp:83: void TimerStack::update(bool UpdateCounts) {
On 2014/12/08 21:08:01, Karl wrote:
> Same here.

Done.

https://codereview.chromium.org/788713002/diff/1/src/IceTimerTree.cpp#newcode117
src/IceTimerTree.cpp:117: void TimerStack::reset() {
On 2014/12/08 21:08:01, Karl wrote:
> Same here.

Done.

[Karl, 2014-12-08 21:45:35]

lgtm

[jvoung (off chromium), 2014-12-08 22:23:05]

lgtm too -- new upload?

[Jim Stichnoth, 2014-12-08 22:31:11]

On 2014/12/08 22:23:05, jvoung wrote:
> lgtm too -- new upload?

Oops, done!

[Jim Stichnoth, 2014-12-08 22:57:58]

Committed patchset #2 (id:20001) manually as
1c44d81950c17d9dac4d5d8e5b65085a753286a9 (presubmit successful).