Chromium Code Reviews
Help | Chromium Project | Sign in
(19)

Issue 7887055: Update checklicenses to pass. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 7 months ago by Paweł Hajdan Jr.
Modified:
3 years, 7 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Update checklicenses to pass. BUG=28291 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=101187

Patch Set 1 #

Total comments: 2

Patch Set 2 : more precise #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M tools/checklicenses/checklicenses.py View 1 3 chunks +11 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
It's amazing that we get regressions there so quickly. I'll be adding this as a ...
3 years, 7 months ago (2011-09-14 22:38:19 UTC) #1
Evan Martin
LGTM http://codereview.chromium.org/7887055/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (right): http://codereview.chromium.org/7887055/diff/1/tools/checklicenses/checklicenses.py#newcode447 tools/checklicenses/checklicenses.py:447: if filename.startswith('out') or filename.startswith('sconsbuild'): consider: 'out/', 'sconsbuild/' (just ...
3 years, 7 months ago (2011-09-14 22:40:11 UTC) #2
Paweł Hajdan Jr.
3 years, 7 months ago (2011-09-14 23:07:38 UTC) #3
http://codereview.chromium.org/7887055/diff/1/tools/checklicenses/checklicens...
File tools/checklicenses/checklicenses.py (right):

http://codereview.chromium.org/7887055/diff/1/tools/checklicenses/checklicens...
tools/checklicenses/checklicenses.py:447: if filename.startswith('out') or
filename.startswith('sconsbuild'):
On 2011/09/14 22:40:11, Evan Martin wrote:
> consider: 'out/', 'sconsbuild/'
> (just so you don't accidentally match a prefix of a longer word)

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld e0e3771