Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: chrome/browser/chromeos/options/wifi_config_view.cc

Issue 788633003: chromeos networking: move from security to securityclass property (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@local-master
Patch Set: rebase, resolve conflicts, update new test data (shill_wifi_dhcp.json) Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/options/wifi_config_view.cc
diff --git a/chrome/browser/chromeos/options/wifi_config_view.cc b/chrome/browser/chromeos/options/wifi_config_view.cc
index 76be879a4ad92a76b880089f04adb5e3a46c13a3..7cd0ea6656d76519ddd43c8f88a5e18bde883e9b 100644
--- a/chrome/browser/chromeos/options/wifi_config_view.cc
+++ b/chrome/browser/chromeos/options/wifi_config_view.cc
@@ -679,17 +679,17 @@ bool WifiConfigView::Login() {
shill::kModeProperty, shill::kModeManaged);
properties.SetBooleanWithoutPathExpansion(
shill::kSaveCredentialsProperty, GetSaveCredentials());
- std::string security = shill::kSecurityNone;
+ std::string security_class = shill::kSecurityNone;
if (!eap_method_combobox_) {
switch (security_combobox_->selected_index()) {
case SECURITY_INDEX_NONE:
- security = shill::kSecurityNone;
+ security_class = shill::kSecurityNone;
break;
case SECURITY_INDEX_WEP:
- security = shill::kSecurityWep;
+ security_class = shill::kSecurityWep;
break;
case SECURITY_INDEX_PSK:
- security = shill::kSecurityPsk;
+ security_class = shill::kSecurityPsk;
break;
}
std::string passphrase = GetPassphrase();
@@ -698,11 +698,11 @@ bool WifiConfigView::Login() {
shill::kPassphraseProperty, GetPassphrase());
}
} else {
- security = shill::kSecurity8021x;
+ security_class = shill::kSecurity8021x;
SetEapProperties(&properties, false /* not configured */);
}
properties.SetStringWithoutPathExpansion(
- shill::kSecurityProperty, security);
+ shill::kSecurityClassProperty, security_class);
// Configure and connect to network.
ui::NetworkConnect::Get()->CreateConfigurationAndConnect(&properties,
@@ -899,7 +899,7 @@ void WifiConfigView::Init(bool show_8021x) {
const NetworkState* network = GetNetworkState();
if (network) {
if (network->type() == shill::kTypeWifi) {
- if (network->security() == shill::kSecurity8021x)
+ if (network->security_class() == shill::kSecurity8021x)
show_8021x = true;
} else if (network->type() == shill::kTypeEthernet) {
show_8021x = true;

Powered by Google App Engine
This is Rietveld 408576698