Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Issue 78863002: fix "may be used uninitialized" warnings for older compilers (Closed)

Created:
7 years, 1 month ago by Mostyn Bramley-Moore
Modified:
7 years ago
Reviewers:
sky
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

fix "may be used uninitialized" warnings for older compilers This small change keeps some slightly older compilers happy (gcc 4.5). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236769

Patch Set 1 #

Patch Set 2 : remove incorrect sanity check #

Patch Set 3 : undo changes to target_thread_outlives_current #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/browser_thread_impl.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Mostyn Bramley-Moore
@sky: PTAL...
7 years, 1 month ago (2013-11-20 16:52:52 UTC) #1
sky
LGTM
7 years, 1 month ago (2013-11-20 21:13:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/78863002/1
7 years, 1 month ago (2013-11-20 21:21:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_browsertests, content_unittests, interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=192845
7 years, 1 month ago (2013-11-20 22:00:00 UTC) #4
Mostyn Bramley-Moore
On 2013/11/20 22:00:00, I haz the power (commit-bot) wrote: > Retried try job too often ...
7 years, 1 month ago (2013-11-20 23:08:35 UTC) #5
Mostyn Bramley-Moore
I think the win_rel failures with the current version of this patch (which only initializes ...
7 years ago (2013-11-22 08:35:45 UTC) #6
sky
LGTM
7 years ago (2013-11-22 14:29:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/78863002/410001
7 years ago (2013-11-22 14:30:42 UTC) #8
commit-bot: I haz the power
7 years ago (2013-11-22 15:53:41 UTC) #9
Message was sent while issue was closed.
Change committed as 236769

Powered by Google App Engine
This is Rietveld 408576698