Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 788613003: Add new GM (filterfastbounds) (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add new GM (filterfastbounds) This new GM visualizes the fast bounds computed by various image-filter-based SkPaints. This is lead up to fixing some issues in fast bound computation. BUG=418417 Committed: https://skia.googlesource.com/skia/+/9a264107fbffd9d029fb74e4dea6bc57beb22254

Patch Set 1 #

Patch Set 2 : Increase OffsetImageFilter offset #

Patch Set 3 : Skip serialization tests due to SkPictureImageFilter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+337 lines, -0 lines) Patch
A gm/filterfastbounds.cpp View 1 2 1 chunk +336 lines, -0 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
robertphillips
6 years ago (2014-12-08 13:42:29 UTC) #2
reed1
lgtm
6 years ago (2014-12-08 16:48:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788613003/20001
6 years ago (2014-12-08 16:49:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1042)
6 years ago (2014-12-08 16:56:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788613003/40001
6 years ago (2014-12-08 17:09:51 UTC) #9
commit-bot: I haz the power
6 years ago (2014-12-08 17:19:03 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/9a264107fbffd9d029fb74e4dea6bc57beb22254

Powered by Google App Engine
This is Rietveld 408576698