Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: src/variables.cc

Issue 7885027: Merge revision 9281 to the 3.5 branch. (Closed) Base URL: http://v8.googlecode.com/svn/branches/3.5/
Patch Set: '' Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/variables.h ('k') | src/version.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 Mode mode, 86 Mode mode,
87 bool is_valid_LHS, 87 bool is_valid_LHS,
88 Kind kind) 88 Kind kind)
89 : scope_(scope), 89 : scope_(scope),
90 name_(name), 90 name_(name),
91 mode_(mode), 91 mode_(mode),
92 kind_(kind), 92 kind_(kind),
93 local_if_not_shadowed_(NULL), 93 local_if_not_shadowed_(NULL),
94 rewrite_(NULL), 94 rewrite_(NULL),
95 is_valid_LHS_(is_valid_LHS), 95 is_valid_LHS_(is_valid_LHS),
96 is_accessed_from_inner_function_scope_(false), 96 is_accessed_from_inner_scope_(false),
97 is_used_(false) { 97 is_used_(false) {
98 // names must be canonicalized for fast equality checks 98 // names must be canonicalized for fast equality checks
99 ASSERT(name->IsSymbol()); 99 ASSERT(name->IsSymbol());
100 } 100 }
101 101
102 102
103 bool Variable::is_global() const { 103 bool Variable::is_global() const {
104 // Temporaries are never global, they must always be allocated in the 104 // Temporaries are never global, they must always be allocated in the
105 // activation frame. 105 // activation frame.
106 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope(); 106 return mode_ != TEMPORARY && scope_ != NULL && scope_->is_global_scope();
107 } 107 }
108 108
109 } } // namespace v8::internal 109 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/variables.h ('k') | src/version.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698