Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 788453002: Put code in //services/window_manager in namespace window_manager (Closed)

Created:
6 years ago by jamesr
Modified:
6 years ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Put code in //services/window_manager in namespace window_manager R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/489c8f1de0cb4833b5b50b95d18f122c8bb82b3c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -277 lines) Patch
M examples/window_manager/window_manager.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.h View 4 chunks +6 lines, -3 lines 0 comments Download
M examples/wm_flow/wm/frame_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M examples/wm_flow/wm/wm.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M services/window_manager/basic_focus_rules.h View 2 chunks +6 lines, -4 lines 0 comments Download
M services/window_manager/basic_focus_rules.cc View 9 chunks +14 lines, -13 lines 0 comments Download
M services/window_manager/focus_controller.h View 6 chunks +23 lines, -25 lines 0 comments Download
M services/window_manager/focus_controller.cc View 4 chunks +7 lines, -5 lines 0 comments Download
M services/window_manager/focus_controller_observer.h View 2 chunks +10 lines, -7 lines 0 comments Download
M services/window_manager/focus_controller_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M services/window_manager/focus_rules.h View 4 chunks +10 lines, -10 lines 0 comments Download
M services/window_manager/main.cc View 4 chunks +19 lines, -13 lines 0 comments Download
M services/window_manager/native_viewport_event_dispatcher_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M services/window_manager/native_viewport_event_dispatcher_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/window_manager/view_event_dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/window_manager/view_event_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/window_manager/view_target.h View 5 chunks +9 lines, -6 lines 0 comments Download
M services/window_manager/view_target.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M services/window_manager/view_target_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M services/window_manager/view_targeter.h View 2 chunks +2 lines, -2 lines 0 comments Download
M services/window_manager/view_targeter.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M services/window_manager/view_targeter_unittest.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M services/window_manager/window_manager_api_unittest.cc View 8 chunks +34 lines, -28 lines 0 comments Download
M services/window_manager/window_manager_app.h View 5 chunks +52 lines, -48 lines 0 comments Download
M services/window_manager/window_manager_app.cc View 11 chunks +37 lines, -28 lines 0 comments Download
M services/window_manager/window_manager_delegate.h View 1 chunk +4 lines, -3 lines 0 comments Download
M services/window_manager/window_manager_impl.h View 3 chunks +17 lines, -15 lines 0 comments Download
M services/window_manager/window_manager_impl.cc View 4 chunks +9 lines, -5 lines 0 comments Download
M services/window_manager/window_manager_test_util.h View 2 chunks +4 lines, -4 lines 0 comments Download
M services/window_manager/window_manager_test_util.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M services/window_manager/window_manager_unittests.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/tools/debugger/debugger.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/tools/debugger/debugger.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/tools/tester/tester.cc View 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jamesr
6 years ago (2014-12-06 01:33:21 UTC) #1
sky
LGTM
6 years ago (2014-12-06 21:18:06 UTC) #2
jamesr
6 years ago (2014-12-08 20:09:01 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
489c8f1de0cb4833b5b50b95d18f122c8bb82b3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698