Make app.alert() actually print its message under pdfium_test.

Make app.alert() actually print its message under pdfium_test.

This is needed as an aid to testing.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/fb9472868e3592d643d064135c7c91e4659962a8

[Tom Sepez, 2014-12-06 00:06:40]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2014-12-06 00:07:47]

Lei, please review.  Is there a better way to do this?  I was opting for
self-containment.  Thanks.

[Lei Zhang, 2014-12-06 00:33:25]

Is the CFX_WideString class useful here?

https://codereview.chromium.org/788433002/diff/20001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/788433002/diff/20001/samples/pdfium_test.cc#n...
samples/pdfium_test.cc:142: size_t characters  = 0;
nit: extra space

https://codereview.chromium.org/788433002/diff/20001/samples/pdfium_test.cc#n...
samples/pdfium_test.cc:146: wchar_t *platform_string =
nit: wchar_t*

[Tom Sepez, 2014-12-06 00:57:33]

Re: CFX_Widestring.  Feels like a layering violation to use this, since I think
we just want the F* API.

https://codereview.chromium.org/788433002/diff/20001/samples/pdfium_test.cc
File samples/pdfium_test.cc (right):

https://codereview.chromium.org/788433002/diff/20001/samples/pdfium_test.cc#n...
samples/pdfium_test.cc:142: size_t characters  = 0;
On 2014/12/06 00:33:25, Lei Zhang wrote:
> nit: extra space

Done.

https://codereview.chromium.org/788433002/diff/20001/samples/pdfium_test.cc#n...
samples/pdfium_test.cc:146: wchar_t *platform_string =
On 2014/12/06 00:33:25, Lei Zhang wrote:
> nit: wchar_t*

Done.

[Lei Zhang, 2014-12-06 01:48:10]

Oh, right. Nothing useful in fpdfsdk/include, so lgtm.

[Tom Sepez, 2014-12-08 17:55:17]

Committed patchset #3 (id:40001) manually as
fb9472868e3592d643d064135c7c91e4659962a8 (presubmit successful).