Convert debugger settings controls to combo boxes.

debugger/QT/SkSettingsWidget.h

 
 /*
  * Copyright 2012 Google Inc.
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SKSETTINGSWIDGET_H_
 #define SKSETTINGSWIDGET_H_
 
 #include <QWidget>
 #include <QHBoxLayout>
 #include <QTextEdit>
 #include <QFrame>
 #include <QGroupBox>
 #include <QLabel>
-#include <QRadioButton>
 #include <QCheckBox>
 #include <QLineEdit>
+#include <QComboBox>
 
 #include "SkPaint.h"
 
 /** \class SkSettingsWidget
 
     The SettingsWidget contains multiple checkboxes and toggles for altering
     the visibility.
  */
 class SkSettingsWidget : public QWidget {
     Q_OBJECT
 
 public:
     /**
         Constructs a widget with the specified parent for layout purposes.
         @param parent  The parent container of this widget
      */
     SkSettingsWidget();
 
     /** Sets the displayed user zoom level. A scale of 1.0 represents no zoom. */
     void setZoomText(float scale);
 

[robertphillips, 2013/11/21 12:52:47]

const?

-    QRadioButton* getVisibilityButton();
+    bool getVisibilityFilter() {
+        return fVisibilityCombo.itemData(fVisibilityCombo.currentIndex()).toBool();
+    }
 
 #if SK_SUPPORT_GPU
     bool isGLActive() {
         return fGLCheckBox.isChecked();
     }
 

[robertphillips, 2013/11/21 12:52:47]

const?

     int getGLSampleCount() {
-        if (fGLMSAA4On.isChecked()) {
-            return 4;
-        } else if (fGLMSAA16On.isChecked()) {
-            return 16;
-        }
-        return 0;
+        return fGLMSAACombo.itemData(fGLMSAACombo.currentIndex()).toInt();
     }
 
 #endif
 

[robertphillips, 2013/11/21 12:52:47]

const?

     bool getFilterOverride(SkPaint::FilterLevel* filterLevel) {
-        if (fFilterDefault.isChecked()) {
-            *filterLevel = SkPaint::kNone_FilterLevel;
-            return false;
-        }
+        int index = fFilterCombo.currentIndex();
+        *filterLevel = (SkPaint::FilterLevel)fFilterCombo.itemData(index).toUInt();
 
-        if (fFilterNone.isChecked()) {
-            *filterLevel = SkPaint::kNone_FilterLevel;
-        } else if (fFilterLow.isChecked()) {
-            *filterLevel = SkPaint::kLow_FilterLevel;
-        } else if (fFilterMed.isChecked()) {
-            *filterLevel = SkPaint::kMedium_FilterLevel;
-        } else {
-            *filterLevel = SkPaint::kHigh_FilterLevel;
-        }
-
-        return true;
+        return index > 0;
     }
 
     QCheckBox* getRasterCheckBox() {
         return &fRasterCheckBox;
     }
 
     QCheckBox* getOverdrawVizCheckBox() {
         return &fOverdrawVizCheckBox;
     }
 
 private slots:
     void updateCommand(int newCommand);
     void updateHit(int newHit);
 
 signals:
     void scrollingPreferences(bool isStickyActivate);
     void showStyle(bool isSingleCommand);
-    void visibilityFilter(bool isEnabled);
+    void visibilityFilterChanged();
     void texFilterSettingsChanged();
 #if SK_SUPPORT_GPU
     void glSettingsChanged();
 #endif
 
 private:
     QVBoxLayout mainFrameLayout;
     QFrame mainFrame;
     QVBoxLayout fVerticalLayout;
 
-    QLabel fVisibileText;
+    QLabel fVisibleText;
     QFrame fVisibleFrame;
     QVBoxLayout fVisibleFrameLayout;
-    QRadioButton fVisibleOn;
-    QRadioButton fVisibleOff;
+    QComboBox fVisibilityCombo;
 
     QLabel fCommandToggle;
     QFrame fCommandFrame;
     QVBoxLayout fCommandLayout;
 
     QHBoxLayout fCurrentCommandLayout;
     QLabel fCurrentCommandLabel;
     QLineEdit fCurrentCommandBox;
 
     QHBoxLayout fCommandHitLayout;
@@ skipping 11 matching lines @@
     QHBoxLayout fOverdrawVizLayout;
     QLabel fOverdrawVizLabel;
     QCheckBox fOverdrawVizCheckBox;
 
 #if SK_SUPPORT_GPU
     QHBoxLayout fGLLayout;
     QLabel fGLLabel;
     QCheckBox fGLCheckBox;
     QGroupBox fGLMSAAButtonGroup;
     QVBoxLayout fGLMSAALayout;
-    QRadioButton fGLMSAAOff;
-    QRadioButton fGLMSAA4On;
-    QRadioButton fGLMSAA16On;
+    QComboBox fGLMSAACombo;
 #endif
 
     // for filtering group
     QGroupBox fFilterButtonGroup;
+    QComboBox fFilterCombo;
     QVBoxLayout fFilterLayout;
-    QRadioButton fFilterDefault;
-    QRadioButton fFilterNone;
-    QRadioButton fFilterLow;
-    QRadioButton fFilterMed;
-    QRadioButton fFilterHigh;
 
     QFrame fZoomFrame;
     QHBoxLayout fZoomLayout;
     QLabel fZoomSetting;
     QLineEdit fZoomBox;
 };
 
 #endif /* SKSETTINGSWIDGET_H_ */