Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 78843005: Convert debugger settings controls to combo boxes. (Closed)

Created:
7 years, 1 month ago by f(malita)
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Convert debugger settings controls to combo boxes. This reduces the height of the settings panel significantly compared to radio buttons. With some luck, the debugger may now fit on non-4K monitors :) R=robertphillips@google.com,bungeman@google.com Committed: http://code.google.com/p/skia/source/detail?r=12342

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -88 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 1 3 chunks +3 lines, -4 lines 0 comments Download
M debugger/QT/SkSettingsWidget.h View 1 5 chunks +17 lines, -39 lines 0 comments Download
M debugger/QT/SkSettingsWidget.cpp View 6 chunks +28 lines, -45 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
f(malita)
7 years, 1 month ago (2013-11-20 23:44:54 UTC) #1
robertphillips
lgtm https://codereview.chromium.org/78843005/diff/1/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/78843005/diff/1/debugger/QT/SkDebuggerGUI.cpp#newcode442 debugger/QT/SkDebuggerGUI.cpp:442: void SkDebuggerGUI::actionCommandFilter() { 1 line now? https://codereview.chromium.org/78843005/diff/1/debugger/QT/SkSettingsWidget.h File ...
7 years, 1 month ago (2013-11-21 12:52:46 UTC) #2
bungeman-skia
lgtm
7 years, 1 month ago (2013-11-21 15:26:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/78843005/90001
7 years, 1 month ago (2013-11-21 15:37:22 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 15:37:31 UTC) #5
Message was sent while issue was closed.
Change committed as 12342

Powered by Google App Engine
This is Rietveld 408576698