Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 788383002: Revert of Remove RenderLayer::collectFragments. (Closed)

Created:
6 years ago by eseidel
Modified:
6 years ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Revert of Remove RenderLayer::collectFragments. (patchset #1 id:1 of https://codereview.chromium.org/778043005/) Reason for revert: This broke hit testing. Hit testing always returns the root node now. :) Original issue's description: > Remove RenderLayer::collectFragments. > > Sky always has exactly one per RenderLayer. This patch > gets rid of the hitTestLayer use of LayerFragment > and gets paintLayerContents to create the list of > fragments itself since it's the only caller. > > Also, delete dead code from LayerFragment.h. > > R=abarth@chromium.org > > Committed: https://chromium.googlesource.com/external/mojo/+/4a3b676dc3387b64575d4a407c90fa8a6f466f4c TBR=esprehn@chromium.org,rafaelw@chromium.org,abarth@chromium.org,ojan@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://chromium.googlesource.com/external/mojo/+/7ed3e0f5a37ae784e7d5fde52361fc8484d95be9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -22 lines) Patch
M sky/engine/core/rendering/LayerFragment.h View 1 chunk +23 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 8 chunks +50 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
Created Revert of Remove RenderLayer::collectFragments.
6 years ago (2014-12-10 22:42:25 UTC) #1
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
6 years ago (2014-12-10 22:42:45 UTC) #3
eseidel
6 years ago (2014-12-10 22:58:52 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7ed3e0f5a37ae784e7d5fde52361fc8484d95be9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698