Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 78833002: Remove state-specific appendTo*/begin* methods from VTTToken (Closed)

Created:
7 years, 1 month ago by fs
Modified:
7 years, 1 month ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove state-specific appendTo*/begin* methods from VTTToken VTTToken has a number of methods that's only intended for use in specific states (and for specific token-types). The naming pattern is appendTo*. After earlier changes, most of these are simple oneliner wrappers that simply append to the VTTToken::m_data buffer. Moving towards an implementation that more closely follow (and resemble) the spec wording, these methods present a problem (and contribute to making the code unnecessarily complex). Replace all appendTo*(...) with appendToData(...), and hoist any ASSERTs into the calling code and simplify them where possible/reasonable. For appendTo{Class,Annotation}, doing this it becomes apparent that VTTToken::m_currentBuffer is redundant with m_buffer, so remove the former in favor of the latter. BUG=319391 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -92 lines) Patch
M Source/core/html/track/vtt/VTTToken.h View 4 chunks +7 lines, -61 lines 0 comments Download
M Source/core/html/track/vtt/VTTTokenizer.h View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/html/track/vtt/VTTTokenizer.cpp View 8 chunks +28 lines, -25 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
fs
7 years, 1 month ago (2013-11-20 16:34:54 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-21 13:18:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/78833002/1
7 years, 1 month ago (2013-11-21 13:33:00 UTC) #3
commit-bot: I haz the power
7 years, 1 month ago (2013-11-21 15:37:34 UTC) #4
Message was sent while issue was closed.
Change committed as 162477

Powered by Google App Engine
This is Rietveld 408576698