DescriptionRemove state-specific appendTo*/begin* methods from VTTToken
VTTToken has a number of methods that's only intended for use in
specific states (and for specific token-types). The naming pattern is
appendTo*. After earlier changes, most of these are simple oneliner
wrappers that simply append to the VTTToken::m_data buffer.
Moving towards an implementation that more closely follow (and resemble)
the spec wording, these methods present a problem (and contribute to
making the code unnecessarily complex).
Replace all appendTo*(...) with appendToData(...), and hoist any ASSERTs
into the calling code and simplify them where possible/reasonable.
For appendTo{Class,Annotation}, doing this it becomes apparent that
VTTToken::m_currentBuffer is redundant with m_buffer, so remove the
former in favor of the latter.
BUG=319391
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162477
Patch Set 1 #
Messages
Total messages: 4 (0 generated)
|