Issue 788283002: Reduce one layer of decoding for binary operations in bitcode reading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 788283002: Reduce one layer of decoding for binary operations in bitcode reading. (Closed)

Created:
6 years ago by Karl

Modified:
6 years ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Reduce one layer of decoding for binary operations in bitcode reading. Removes the need to call function llvm::DecodeBinaryOp. In turn, this removes the need for enum type llvm::Instruction::BinaryOps, llvm::Type.isFPOrFPVectorTy, and one call to llvm::convertToLLVMType. BUG= None R=jvoung@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9bb188d8afbc0b7d3cde3334cca56b8a09301443

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -60 lines)			Patch
	M	src/PNaClTranslator.cpp	View		4 chunks	+56 lines, -60 lines	0 comments	Download
	M	tests_lit/llvm2ice_tests/mangle.ll	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

Karl

6 years ago (2014-12-10 20:54:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9bb188d8afbc0b7d3cde3334cca56b8a09301443 (presubmit successful).