Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 788243002: Revert of Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpda... (Closed)

Created:
6 years ago by earthdok
Modified:
6 years ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpda... (patchset #2 id:250001 of https://codereview.chromium.org/790183002/) Reason for revert: Accidentally committed without CQ, broke build :( Original issue's description: > Revert of Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpdaterCros. (patchset #7 id:120001 of https://codereview.chromium.org/738843002/) > > Reason for revert: > Speculative revert to see if this is the cause of issue 440063. > > BUG=440063 > TBR=ygorshenin@chromium.org > > Original issue's description: > > Call to CrosSettings::Set() is replaced by OwnerSettingsService::Set() in VersionUpdaterCros. Also, fixed permissions checks for channel switcher UI in a multi-profiles sessions. > > > > BUG=433840 > > TEST=existing unit_tests for OwnerSettingsService > > > > Committed: https://crrev.com/e0ed5a18bc9e3fa930f1af3b8f9c3cfdb91329f5 > > Cr-Commit-Position: refs/heads/master@{#305012} > > TBR=nkostylev@chromium.org,ygorshenin@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=433840 > > Committed: https://crrev.com/ed8e4785e42fdf65d79656fb922f2d1b16e9857b > Cr-Commit-Position: refs/heads/master@{#307710} TBR=nkostylev@chromium.org,ygorshenin@chromium.org NOTREECHECKS=true NOTRY=true BUG=440063 Committed: https://crrev.com/48f2d7ba8eeb704b9bcfb566b2ff50bf44e357f1 Cr-Commit-Position: refs/heads/master@{#307712}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -51 lines) Patch
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.h View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_service_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/settings/device_settings_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/session_manager_operation_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/flags_ui.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 8 chunks +25 lines, -12 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_basic.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos.cc View 5 chunks +17 lines, -10 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/help/version_updater_mac.mm View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/help/version_updater_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/core_chromeos_options_handler.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
earthdok
6 years ago (2014-12-10 16:20:46 UTC) #1
Created Revert of Revert of Call to CrosSettings::Set() is replaced by
OwnerSettingsService::Set() in VersionUpda...

Powered by Google App Engine
This is Rietveld 408576698