device/bluetooth/bluetooth_remote_gatt_service_chromeos.h - Issue 788193004: chromeos/dbus: Update Bluetooth GATT API clients to upstream definition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/bluetooth/bluetooth_remote_gatt_service_chromeos.h

Issue 788193004: chromeos/dbus: Update Bluetooth GATT API clients to upstream definition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« device/bluetooth/bluetooth_gatt_chromeos_unittest.cc ('K') | « device/bluetooth/bluetooth_remote_gatt_descriptor_chromeos.cc ('k') | device/bluetooth/bluetooth_remote_gatt_service_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: device/bluetooth/bluetooth_remote_gatt_service_chromeos.h

diff --git a/device/bluetooth/bluetooth_remote_gatt_service_chromeos.h b/device/bluetooth/bluetooth_remote_gatt_service_chromeos.h

index 49b62627e97b147d324b9f97b1d5287558af6dee..e9d42e14fcd1f9cdffca093976a90ead181f1eaa 100644

--- a/device/bluetooth/bluetooth_remote_gatt_service_chromeos.h

+++ b/device/bluetooth/bluetooth_remote_gatt_service_chromeos.h

@@ -75,14 +75,6 @@ class BluetoothRemoteGattServiceChromeOS

// service observers when characteristic descriptors get added and removed.

void NotifyServiceChanged();

- // Notifies its observers that the value of a characteristic has changed.

- // Called by BluetoothRemoteGattCharacteristicChromeOS instances to notify

- // service observers when their cached value is updated after a successful

- // read request or when a "ValueUpdated" signal is received.

- void NotifyCharacteristicValueChanged(

- BluetoothRemoteGattCharacteristicChromeOS* characteristic,

- const std::vector<uint8>& value);

// Notifies its observers that a descriptor |descriptor| belonging to

// characteristic |characteristic| has been added or removed. This is used

// by BluetoothRemoteGattCharacteristicChromeOS instances to notify service

@@ -95,8 +87,8 @@ class BluetoothRemoteGattServiceChromeOS

bool added);

// Notifies its observers that the value of a descriptor has changed. Called

- // by BluetoothRemoteGattDescriptorChromeOS instances to notify service

- // observers when their cached value gets updated after a read request.

+ // by BluetoothRemoteGattCharacteristicChromeOS instances to notify service

+ // observers.

void NotifyDescriptorValueChanged(

BluetoothRemoteGattCharacteristicChromeOS* characteristic,

BluetoothRemoteGattDescriptorChromeOS* descriptor,