Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3490)

Unified Diff: chromeos/dbus/bluetooth_gatt_characteristic_client.h

Issue 788193004: chromeos/dbus: Update Bluetooth GATT API clients to upstream definition (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/bluetooth_gatt_characteristic_client.h
diff --git a/chromeos/dbus/bluetooth_gatt_characteristic_client.h b/chromeos/dbus/bluetooth_gatt_characteristic_client.h
index ab5fd702dfb03f5175c0d59fff906da4c589f59b..ca8bbb45727882582b8a43cf5fcc66440719c75b 100644
--- a/chromeos/dbus/bluetooth_gatt_characteristic_client.h
+++ b/chromeos/dbus/bluetooth_gatt_characteristic_client.h
@@ -6,6 +6,7 @@
#define CHROMEOS_DBUS_BLUETOOTH_GATT_CHARACTERISTIC_CLIENT_H_
#include <string>
+#include <vector>
#include "base/basictypes.h"
#include "base/callback.h"
@@ -29,6 +30,11 @@ class CHROMEOS_EXPORT BluetoothGattCharacteristicClient : public DBusClient {
// [read-only]
dbus::Property<dbus::ObjectPath> service;
+ // The chached value of the characteristic. This property gets updated only
armansito 2014/12/19 06:03:58 nit: s/chached/cached/
armansito 2015/02/03 01:54:38 Done.
+ // after a successful read request and when a notification or indication is
+ // received. [read-only]
+ dbus::Property<std::vector<uint8_t>> value;
+
// Whether or not this characteristic is currently sending ValueUpdated
// signals. [read-only]
dbus::Property<bool> notifying;
@@ -36,11 +42,11 @@ class CHROMEOS_EXPORT BluetoothGattCharacteristicClient : public DBusClient {
// List of flags representing the GATT "Characteristic Properties bit field"
// and properties read from the GATT "Characteristic Extended Properties"
// descriptor bit field. [read-only, optional]
- dbus::Property<std::vector<std::string> > flags;
+ dbus::Property<std::vector<std::string>> flags;
// Array of object paths representing the descriptors of this
// characteristic. [read-only]
- dbus::Property<std::vector<dbus::ObjectPath> > descriptors;
+ dbus::Property<std::vector<dbus::ObjectPath>> descriptors;
Properties(dbus::ObjectProxy* object_proxy,
const std::string& interface_name,
@@ -67,13 +73,6 @@ class CHROMEOS_EXPORT BluetoothGattCharacteristicClient : public DBusClient {
virtual void GattCharacteristicPropertyChanged(
const dbus::ObjectPath& object_path,
const std::string& property_name) {}
-
- // Called when a "ValueUpdated" signal is received from the remote GATT
- // characteristic with object path |object_path| with characteristic value
- // |value|.
- virtual void GattCharacteristicValueUpdated(
- const dbus::ObjectPath& object_path,
- const std::vector<uint8>& value) {}
};
// Callbacks used to report the result of asynchronous methods.

Powered by Google App Engine
This is Rietveld 408576698