chromeos/dbus: Update Bluetooth GATT API clients to upstream definition

chromeos/dbus: Update Bluetooth GATT API clients to upstream definition

This CL ports the GATT API bindings from the D-Bus API in our Chrome OS fork to
the API definition in doc/gatt-api.txt in BlueZ upstream.

TBR=keybuk@chromium.org
BUG=440968
Committed: https://crrev.com/2e5cbe58a08a122c8896ae6542b5822a827a1707
Cr-Commit-Position: refs/heads/master@{#315095}

[armansito, 2014-12-10 22:20:55]

armansito@chromium.org changed reviewers:
+ jamuraa@chromium.org

[armansito, 2014-12-10 22:20:56]

PTAL. I'll hold off on merging this until the D-Bus API patches have been merged
upstream, make it into a BlueZ release (probably 5.27 or 6), and we have pulled
the update into our tree.

[Marie Janssen, 2014-12-11 23:18:52]

lgtm with one testing nit

https://codereview.chromium.org/788193004/diff/1/device/bluetooth/bluetooth_g...
File device/bluetooth/bluetooth_gatt_chromeos_unittest.cc (right):

https://codereview.chromium.org/788193004/diff/1/device/bluetooth/bluetooth_g...
device/bluetooth/bluetooth_gatt_chromeos_unittest.cc:1161:
characteristic->StartNotifySession(
You should EXPECT_FALSE(characteristic->IsNotifying()) before this to confirm
this is the change

[armansito, 2014-12-19 06:03:58]

Thanks for looking, I won't fix these until the API is implemented in BlueZ
upstream, made it to a release, and we have it in the tree.

In the meantime I saw a typo, so added a note.

https://codereview.chromium.org/788193004/diff/1/chromeos/dbus/bluetooth_gatt...
File chromeos/dbus/bluetooth_gatt_characteristic_client.h (right):

https://codereview.chromium.org/788193004/diff/1/chromeos/dbus/bluetooth_gatt...
chromeos/dbus/bluetooth_gatt_characteristic_client.h:33: // The chached value of
the characteristic. This property gets updated only
nit: s/chached/cached/

[armansito, 2015-02-03 01:54:39]

https://codereview.chromium.org/788193004/diff/1/chromeos/dbus/bluetooth_gatt...
File chromeos/dbus/bluetooth_gatt_characteristic_client.h (right):

https://codereview.chromium.org/788193004/diff/1/chromeos/dbus/bluetooth_gatt...
chromeos/dbus/bluetooth_gatt_characteristic_client.h:33: // The chached value of
the characteristic. This property gets updated only
On 2014/12/19 06:03:58, armansito wrote:
> nit: s/chached/cached/

Done.

https://codereview.chromium.org/788193004/diff/1/device/bluetooth/bluetooth_g...
File device/bluetooth/bluetooth_gatt_chromeos_unittest.cc (right):

https://codereview.chromium.org/788193004/diff/1/device/bluetooth/bluetooth_g...
device/bluetooth/bluetooth_gatt_chromeos_unittest.cc:1161:
characteristic->StartNotifySession(
On 2014/12/11 23:18:52, Michael Janssen wrote:
> You should EXPECT_FALSE(characteristic->IsNotifying()) before this to confirm
> this is the change

Done.

[armansito, 2015-02-06 14:22:10]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2015-02-06 14:22:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788193004/20001

[commit-bot: I haz the power, 2015-02-06 14:22:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-06 14:22:36]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[armansito, 2015-02-06 19:34:01]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2015-02-06 19:34:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788193004/40001

[commit-bot: I haz the power, 2015-02-06 20:21:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-06 20:22:13]

Patchset 3 (id:??) landed as
https://crrev.com/2e5cbe58a08a122c8896ae6542b5822a827a1707
Cr-Commit-Position: refs/heads/master@{#315095}