Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 788183004: Add a flag for fill on account select without highlighting (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Rebase on ToT Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 364 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 { IDS_FLAGS_SSL_VERSION_SSLV3, switches::kSSLVersionMin, 375 { IDS_FLAGS_SSL_VERSION_SSLV3, switches::kSSLVersionMin,
376 switches::kSSLVersionSSLv3 }, 376 switches::kSSLVersionSSLv3 },
377 { IDS_FLAGS_SSL_VERSION_TLSV1, switches::kSSLVersionMin, 377 { IDS_FLAGS_SSL_VERSION_TLSV1, switches::kSSLVersionMin,
378 switches::kSSLVersionTLSv1 }, 378 switches::kSSLVersionTLSv1 },
379 { IDS_FLAGS_SSL_VERSION_TLSV11, switches::kSSLVersionMin, 379 { IDS_FLAGS_SSL_VERSION_TLSV11, switches::kSSLVersionMin,
380 switches::kSSLVersionTLSv11 }, 380 switches::kSSLVersionTLSv11 },
381 { IDS_FLAGS_SSL_VERSION_TLSV12, switches::kSSLVersionMin, 381 { IDS_FLAGS_SSL_VERSION_TLSV12, switches::kSSLVersionMin,
382 switches::kSSLVersionTLSv12 }, 382 switches::kSSLVersionTLSv12 },
383 }; 383 };
384 384
385 const Experiment::Choice kFillOnAccountSelectChoices[] = {
386 { IDS_GENERIC_EXPERIMENT_CHOICE_DEFAULT, "", "" },
387 { IDS_GENERIC_EXPERIMENT_CHOICE_DISABLED,
388 autofill::switches::kDisableFillOnAccountSelect, "" },
389 { IDS_FLAGS_FILL_ON_ACCOUNT_SELECT_ENABLE_HIGHLIGHTING,
390 autofill::switches::kEnableFillOnAccountSelect, "" },
391 { IDS_FLAGS_FILL_ON_ACCOUNT_SELECT_ENABLE_NO_HIGHLIGHTING,
392 autofill::switches::kEnableFillOnAccountSelectNoHighlighting, "" },
393 };
394
385 // RECORDING USER METRICS FOR FLAGS: 395 // RECORDING USER METRICS FOR FLAGS:
386 // ----------------------------------------------------------------------------- 396 // -----------------------------------------------------------------------------
387 // The first line of the experiment is the internal name. If you'd like to 397 // The first line of the experiment is the internal name. If you'd like to
388 // gather statistics about the usage of your flag, you should append a marker 398 // gather statistics about the usage of your flag, you should append a marker
389 // comment to the end of the feature name, like so: 399 // comment to the end of the feature name, like so:
390 // "my-special-feature", // FLAGS:RECORD_UMA 400 // "my-special-feature", // FLAGS:RECORD_UMA
391 // 401 //
392 // After doing that, run 402 // After doing that, run
393 // tools/metrics/actions/extract_actions.py 403 // tools/metrics/actions/extract_actions.py
394 // to add the metric to actions.xml (which will enable UMA to record your 404 // to add the metric to actions.xml (which will enable UMA to record your
(...skipping 1682 matching lines...) Expand 10 before | Expand all | Expand 10 after
2077 IDS_FLAGS_ENABLE_TOUCH_HOVER_NAME, 2087 IDS_FLAGS_ENABLE_TOUCH_HOVER_NAME,
2078 IDS_FLAGS_ENABLE_TOUCH_HOVER_DESCRIPTION, 2088 IDS_FLAGS_ENABLE_TOUCH_HOVER_DESCRIPTION,
2079 kOsAndroid, 2089 kOsAndroid,
2080 SINGLE_VALUE_TYPE("enable-touch-hover") 2090 SINGLE_VALUE_TYPE("enable-touch-hover")
2081 }, 2091 },
2082 { 2092 {
2083 "enable-fill-on-account-select", 2093 "enable-fill-on-account-select",
2084 IDS_FILL_ON_ACCOUNT_SELECT_NAME, 2094 IDS_FILL_ON_ACCOUNT_SELECT_NAME,
2085 IDS_FILL_ON_ACCOUNT_SELECT_DESCRIPTION, 2095 IDS_FILL_ON_ACCOUNT_SELECT_DESCRIPTION,
2086 kOsAll, 2096 kOsAll,
2087 ENABLE_DISABLE_VALUE_TYPE(autofill::switches::kEnableFillOnAccountSelect, 2097 MULTI_VALUE_TYPE(kFillOnAccountSelectChoices)
2088 autofill::switches::kDisableFillOnAccountSelect)
2089 }, 2098 },
2090 2099
2091 // NOTE: Adding new command-line switches requires adding corresponding 2100 // NOTE: Adding new command-line switches requires adding corresponding
2092 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2101 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2093 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2102 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2094 }; 2103 };
2095 2104
2096 const Experiment* experiments = kExperiments; 2105 const Experiment* experiments = kExperiments;
2097 size_t num_experiments = arraysize(kExperiments); 2106 size_t num_experiments = arraysize(kExperiments);
2098 2107
(...skipping 560 matching lines...) Expand 10 before | Expand all | Expand 10 after
2659 } 2668 }
2660 2669
2661 const Experiment* GetExperiments(size_t* count) { 2670 const Experiment* GetExperiments(size_t* count) {
2662 *count = num_experiments; 2671 *count = num_experiments;
2663 return experiments; 2672 return experiments;
2664 } 2673 }
2665 2674
2666 } // namespace testing 2675 } // namespace testing
2667 2676
2668 } // namespace about_flags 2677 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698