Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(732)

Issue 788183004: Add a flag for fill on account select without highlighting (Closed)

Created:
6 years ago by jww
Modified:
6 years ago
Reviewers:
Garrett Casto
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, rolfe
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a flag for fill on account select without highlighting In the fill on account select password manager experiment, the enabled setting still highlights the fields that can be autofilled. This adds an experimental group where the fields will not be highlighted even if they can be autofilled until after a choice has been selected. R=gcasto@chromium.org TBR=isherman@chromium.org BUG=410963 Committed: https://crrev.com/c3ab6e7bc14266e53a68c887d927c0937e5dcae7 Cr-Commit-Position: refs/heads/master@{#309558}

Patch Set 1 #

Patch Set 2 : Rebase on ToT #

Patch Set 3 : Fixed histograms.xml #

Patch Set 4 : Rebase on ToT #

Patch Set 5 : Rebase on ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -8 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 4 2 chunks +11 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/content/renderer/password_autofill_agent.cc View 1 2 3 4 3 chunks +38 lines, -5 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +7 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (11 generated)
jww
Garrett, can you take a look at this? In an offline discussion, rolfe@ suggested a ...
6 years ago (2014-12-16 00:37:19 UTC) #1
Garrett Casto
lgtm
6 years ago (2014-12-20 00:37:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788183004/1
6 years ago (2014-12-20 00:37:45 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/builds/43938) ios_rel_device_ninja on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ninja/builds/38442)
6 years ago (2014-12-20 00:40:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788183004/20001
6 years ago (2014-12-20 01:56:28 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/16821)
6 years ago (2014-12-20 02:58:40 UTC) #10
jww
Added isherman@ as TBR for histograms.xml
6 years ago (2014-12-22 19:17:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788183004/40001
6 years ago (2014-12-22 19:19:07 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/45267)
6 years ago (2014-12-22 19:32:45 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788183004/60001
6 years ago (2014-12-22 20:13:20 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/45284)
6 years ago (2014-12-22 20:24:29 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788183004/60001
6 years ago (2014-12-22 22:21:31 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788183004/80001
6 years ago (2014-12-23 16:20:44 UTC) #24
commit-bot: I haz the power
Committed patchset #5 (id:80001)
6 years ago (2014-12-23 18:16:59 UTC) #25
commit-bot: I haz the power
6 years ago (2014-12-23 18:17:51 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/c3ab6e7bc14266e53a68c887d927c0937e5dcae7
Cr-Commit-Position: refs/heads/master@{#309558}

Powered by Google App Engine
This is Rietveld 408576698