Should set the modifiers for web mouse event on Mac.

Source/web/WebInputEventFactoryMac.mm

 /*
  * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006-2009 Google Inc.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 704 matching lines @@
     if ([event modifierFlags] & NSControlKeyMask)
         modifiers |= WebInputEvent::ControlKey;
     if ([event modifierFlags] & NSShiftKeyMask)
         modifiers |= WebInputEvent::ShiftKey;
     if ([event modifierFlags] & NSAlternateKeyMask)
         modifiers |= WebInputEvent::AltKey;
     if ([event modifierFlags] & NSCommandKeyMask)
         modifiers |= WebInputEvent::MetaKey;
     if ([event modifierFlags] & NSAlphaShiftKeyMask)
         modifiers |= WebInputEvent::CapsLockOn;
-    // TODO(port): Set mouse button states
+    if ([NSEvent pressedMouseButtons] & 1 << 0)

[haraken, 2014/12/11 16:24:13]

Don't we want to have a constant variable for 1 << 0? At least, let's add '('
and ')' around 1 << 0.

[zino, 2014/12/11 17:01:28]

Done.

IMHO, it is better to use constant values here than constant variables.
Because the values will be used only here.
I added some comments instead.

+        modifiers |= WebInputEvent::LeftButtonDown;
+    if ([NSEvent pressedMouseButtons] & 1 << 1)
+        modifiers |= WebInputEvent::RightButtonDown;
+    if ([NSEvent pressedMouseButtons] & 1 << 2)
+        modifiers |= WebInputEvent::MiddleButtonDown;
 
     return modifiers;
 }
 
 static inline void setWebEventLocationFromEventInView(WebMouseEvent* result,
                                                       NSEvent* event,
                                                       NSView* view) {
     NSPoint windowLocal = [event locationInWindow];
 
     NSPoint screenLocal = [[view window] convertBaseToScreen:windowLocal];
@@ skipping 404 matching lines @@
         break;
     default:
         ASSERT_NOT_REACHED();
         result.type = WebInputEvent::Undefined;
     }
 
     return result;
 }
 
 } // namespace blink