Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 788163006: Move shared partner customizations test code into the correct folder. (Closed)

Created:
5 years, 11 months ago by newt (away)
Modified:
5 years, 11 months ago
Reviewers:
aruslan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move shared partner customizations test code into the correct folder. Test code that's used downstream needs to live in chrome/test/android/javatests (which is included in the chrome_java_test_support target), not chrome/android/javatests (which is included only in the chrome_shell_test_apk target). BUG=444675 Committed: https://crrev.com/5d49353ab0c34c986026fe5dca8b60e5e98999f9 Cr-Commit-Position: refs/heads/master@{#311530}

Patch Set 1 #

Patch Set 2 : shortened package name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -203 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/BasePartnerBrowserCustomizationUnitTest.java View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerDisableBookmarksEditingUnitTest.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerDisableIncognitoModeUnitTest.java View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/PartnerHomepageUnitTest.java View 1 1 chunk +2 lines, -0 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/TestPartnerBrowserCustomizationsDelayedProvider.java View 1 chunk +0 lines, -65 lines 0 comments Download
D chrome/android/javatests/src/org/chromium/chrome/browser/partnercustomizations/TestPartnerBrowserCustomizationsProvider.java View 1 chunk +0 lines, -132 lines 0 comments Download
M chrome/android/shell/javatests/AndroidManifest.xml View 1 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/test/android/javatests/src/org/chromium/chrome/test/partnercustomizations/TestPartnerBrowserCustomizationsDelayedProvider.java View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/test/android/javatests/src/org/chromium/chrome/test/partnercustomizations/TestPartnerBrowserCustomizationsProvider.java View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
newt (away)
PTAL
5 years, 11 months ago (2015-01-14 17:49:26 UTC) #2
aruslan
lgtm assuming test.util.browser is a correct package and not some hideous attempt to get the ...
5 years, 11 months ago (2015-01-14 17:56:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788163006/20001
5 years, 11 months ago (2015-01-14 18:45:39 UTC) #5
newt (away)
On 2015/01/14 17:56:19, aruslan wrote: > lgtm assuming test.util.browser is a correct package and not ...
5 years, 11 months ago (2015-01-14 18:46:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 11 months ago (2015-01-14 19:35:49 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 19:37:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d49353ab0c34c986026fe5dca8b60e5e98999f9
Cr-Commit-Position: refs/heads/master@{#311530}

Powered by Google App Engine
This is Rietveld 408576698