LayoutTests/editing/execCommand/insertImage-src.html - Issue 788153003: Make execCommand("insertImage", false, "") not add a src attribute

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/execCommand/insertImage-src.html

Issue 788153003: Make execCommand("insertImage", false, "") not add a src attribute (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>execCommand("insertImage") src attribute</title>

	5 <script src="../../resources/testharness.js"></script>

	6 <script src="../../resources/testharnessreport.js"></script>

	7 </head>

	8 <body>

	9 <div id="log"></div>

	10 <script>

	11 function t(value, innerHTML) {

	12 test(function() {
	Yuta Kitamura 2014/12/11 02:35:50 We usually apply Blink's (C++) coding style in Jav We usually apply Blink's (C++) coding style in JavaScript in layout tests, too, i.e. 4-space indent, no abbreviation in variable names, etc. philipj_slow 2014/12/11 08:20:38 http://www.chromium.org/blink/coding-style/layout- Show quoted text On 2014/12/11 02:35:50, Yuta Kitamura wrote: > We usually apply Blink's (C++) coding style in JavaScript in > layout tests, too, i.e. 4-space indent, no abbreviation in > variable names, etc. http://www.chromium.org/blink/coding-style/layout-test-style-guidelines actually explicitly allows both styles of indentation and braces now, but you're right, most other tests in this directory have four spaces of indentation, so I'll adapt to that and expand the variable name.
	13 var e = document.createElement("div");

	14 e.contentEditable = true;

	15 document.body.appendChild(e);

	16 e.focus();

	17 document.execCommand("insertImage", false, value);

	18 assert_equals(e.innerHTML, innerHTML);

	19 document.body.removeChild(e);

	20 }, 'document.execCommand("insertImage", false, ' + value + ')');

	21 }

	22 t(undefined, "<img>");

	23 t(null, "<img>");

	24 t("", "<img>");

	25 t(" ", '<img src=" ">');

	26 t("image", '<img src="image">');

	27 </script>

	28 </body>

	29 </html>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/editing/EditorCommand.cpp » ('j') | no next file with comments »