Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 788143004: Update strict mode function declaration tests before block scoping. (Closed)

Created:
6 years ago by Dmitry Lomov (no reviews)
Modified:
6 years ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Update strict mode function declaration tests before block scoping. R=arv@chromium.org,marja@chromium.org BUG=v8:2198 LOG=N

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -18 lines) Patch
M test/preparser/strict-function-statement.pyt View 1 chunk +24 lines, -17 lines 0 comments Download
M test/preparser/testcfg.py View 1 chunk +2 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dmitry Lomov (no reviews)
Contrary to what I claimed before, ES6 actually allows function declarations in blocks. 1 .Passed ...
6 years ago (2014-12-10 19:19:26 UTC) #1
arv (Not doing code reviews)
LGTM
6 years ago (2014-12-10 19:36:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788143004/1
6 years ago (2014-12-10 19:47:37 UTC) #4
commit-bot: I haz the power
6 years ago (2014-12-10 20:09:37 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698