Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 788113003: Revert of Make the sort order in thumbnail view always alphabetical. (Closed)

Created:
6 years ago by fukino
Modified:
6 years ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Make the sort order in thumbnail view always alphabetical. Original issue's description: > Make the sort order in thumbnail view always alphabetical. > > Implemented sort related wrapper to ListContainer to fix the actual sort order > in thumbnail view in alphabetical order. > > BUG=438915 > TEST=sort files non-alphabetically in list view, change view to grid view, and confirm the sort order is alphabetical. > After that, change view to list view, and confirm that the first sort order is restored. > > Committed: https://crrev.com/bd854587a2e1b3ca8e7b13299e3d74978b1933f9 > Cr-Commit-Position: refs/heads/master@{#307233} BUG=438915, 440659 TBR=hirono@chromium.org Committed: https://crrev.com/feffe1dd547ee7b5c16d38784cd0cd679dfd7850 Cr-Commit-Position: refs/heads/master@{#307650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -176 lines) Patch
M chrome/browser/chromeos/file_manager/file_manager_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/app_state_controller.js View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/list_container.js View 4 chunks +0 lines, -48 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/grid_view.js View 3 chunks +29 lines, -124 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788113003/1
6 years ago (2014-12-10 06:16:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-10 06:58:02 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-10 06:58:45 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/feffe1dd547ee7b5c16d38784cd0cd679dfd7850
Cr-Commit-Position: refs/heads/master@{#307650}

Powered by Google App Engine
This is Rietveld 408576698