Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 788113002: Simplify HTMLStyleElement. (Closed)

Created:
6 years ago by esprehn
Modified:
6 years ago
Reviewers:
ojan, eseidel
CC:
abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Simplify HTMLStyleElement. The parser will never insert more than one child into a <style>, so we don't need explicit logic to batch up parsing. Once I removed that it exposed that all the line number and parser created logic is from error reporting in the parser that's been dead in Blink for over a year. By doing this simplification I was able to remove the finishParsingChildren() callback entirely. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/08a9c63f1a9f6259ce128e1273bc10d783951567

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -131 lines) Patch
M sky/engine/core/css/CSSTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser.h View 4 chunks +2 lines, -7 lines 0 comments Download
M sky/engine/core/css/parser/BisonCSSParser-in.cpp View 6 chunks +1 line, -27 lines 0 comments Download
M sky/engine/core/css/parser/CSSGrammar.y View 3 chunks +0 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +0 lines, -8 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.h View 2 chunks +1 line, -3 lines 0 comments Download
M sky/engine/core/dom/StyleEngine.cpp View 2 chunks +5 lines, -13 lines 0 comments Download
M sky/engine/core/html/HTMLStyleElement.h View 3 chunks +2 lines, -9 lines 0 comments Download
M sky/engine/core/html/HTMLStyleElement.cpp View 6 chunks +5 lines, -22 lines 0 comments Download
M sky/engine/core/html/HTMLTagNames.in View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLConstructionSite.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M sky/engine/core/html/parser/HTMLElementStack.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/html/parser/HTMLElementStack.cpp View 2 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
esprehn
6 years ago (2014-12-10 01:27:25 UTC) #2
eseidel
lgtm
6 years ago (2014-12-10 01:58:41 UTC) #3
esprehn
6 years ago (2014-12-10 03:01:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
08a9c63f1a9f6259ce128e1273bc10d783951567 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698