Issue 788093003: Add clear() to Element.classList.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 788093003: Add clear() to Element.classList. (Closed)

Created:
6 years ago by esprehn

Modified:
6 years ago

Reviewers:
rafaelw, ojan

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

Add clear() to Element.classList. We should support a fast way to remove all classes through the classList instead of having to call removeAttribute() directly. BUG=440529 R=ojan@chromium.org, rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/1ab476bdbf6a87ec1a0c3916dc2df2267c730532

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -7 lines)			Patch
M	sky/engine/core/dom/DOMTokenList.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sky/engine/core/dom/DOMTokenList.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sky/engine/core/dom/DOMTokenList.idl	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	sky/tests/lowlevel/classlist.sky	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	sky/tests/lowlevel/classlist-expected.txt	View	1 chunk	+8 lines, -7 lines	0 comments	Download

Total messages: 5 (1 generated)

esprehn

6 years ago (2014-12-10 01:56:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1ab476bdbf6a87ec1a0c3916dc2df2267c730532 (presubmit successful).