Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Unified Diff: Source/core/rendering/RenderVideo.cpp

Issue 788073004: Replace RenderFullscreen with top layer - Take II (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated after review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderVideo.cpp
diff --git a/Source/core/rendering/RenderVideo.cpp b/Source/core/rendering/RenderVideo.cpp
index 346b506a57b4229bd53972e6b087ea81ce47219c..5b2e32d270836bc6345fe0ee8017adf258fe5ce8 100644
--- a/Source/core/rendering/RenderVideo.cpp
+++ b/Source/core/rendering/RenderVideo.cpp
@@ -34,7 +34,6 @@
#include "core/html/HTMLVideoElement.h"
#include "core/paint/VideoPainter.h"
#include "core/rendering/PaintInfo.h"
-#include "core/rendering/RenderFullScreen.h"
#include "platform/graphics/media/MediaPlayer.h"
#include "public/platform/WebLayer.h"
@@ -205,47 +204,6 @@ bool RenderVideo::supportsAcceleratedRendering() const
return !!mediaElement()->platformLayer();
}
-static const RenderBlock* rendererPlaceholder(const RenderObject* renderer)
-{
- RenderObject* parent = renderer->parent();
- if (!parent)
- return 0;
-
- RenderFullScreen* fullScreen = parent->isRenderFullScreen() ? toRenderFullScreen(parent) : 0;
- if (!fullScreen)
- return 0;
-
- return fullScreen->placeholder();
-}
-
-LayoutUnit RenderVideo::offsetLeft() const
-{
- if (const RenderBlock* block = rendererPlaceholder(this))
- return block->offsetLeft();
- return RenderMedia::offsetLeft();
-}
-
-LayoutUnit RenderVideo::offsetTop() const
-{
- if (const RenderBlock* block = rendererPlaceholder(this))
- return block->offsetTop();
- return RenderMedia::offsetTop();
-}
-
-LayoutUnit RenderVideo::offsetWidth() const
-{
- if (const RenderBlock* block = rendererPlaceholder(this))
- return block->offsetWidth();
- return RenderMedia::offsetWidth();
-}
-
-LayoutUnit RenderVideo::offsetHeight() const
-{
- if (const RenderBlock* block = rendererPlaceholder(this))
- return block->offsetHeight();
- return RenderMedia::offsetHeight();
-}
-
CompositingReasons RenderVideo::additionalCompositingReasons() const
{
if (RuntimeEnabledFeatures::overlayFullscreenVideoEnabled()) {

Powered by Google App Engine
This is Rietveld 408576698