Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Unified Diff: Source/core/dom/Fullscreen.h

Issue 788073004: Replace RenderFullscreen with top layer - Take II (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated after review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/Fullscreen.h
diff --git a/Source/core/dom/Fullscreen.h b/Source/core/dom/Fullscreen.h
index 5257fa7f566b89824af57c84f69da7c8f9bccf1d..04f4fb7c76e09d362b2eaec495e607c47e0d3232 100644
--- a/Source/core/dom/Fullscreen.h
+++ b/Source/core/dom/Fullscreen.h
@@ -40,7 +40,6 @@
namespace blink {
-class RenderFullScreen;
class RenderStyle;
class Fullscreen final
@@ -74,10 +73,6 @@ public:
void didEnterFullScreenForElement(Element*);
void didExitFullScreenForElement(Element*);
- void setFullScreenRenderer(RenderFullScreen*);
- RenderFullScreen* fullScreenRenderer() const { return m_fullScreenRenderer; }
- void fullScreenRendererDestroyed();
-
void elementRemoved(Element&);
// Mozilla API
@@ -90,6 +85,8 @@ public:
virtual void trace(Visitor*) override;
+ const WillBeHeapVector<std::pair<RefPtrWillBeMember<Element>, RequestType> >& fullScreenElementStack() { return m_fullScreenElementStack; }
philipj_slow 2015/02/12 08:19:16 Can you comment that this is exposed for tests onl
esprehn 2015/02/20 06:23:45 Just name it fullScreenElementStackForTesting()
+
private:
static Fullscreen* fromIfExistsSlow(Document&);
@@ -107,7 +104,6 @@ private:
RefPtrWillBeMember<Element> m_fullScreenElement;
WillBeHeapVector<std::pair<RefPtrWillBeMember<Element>, RequestType> > m_fullScreenElementStack;
- RawPtrWillBeMember<RenderFullScreen> m_fullScreenRenderer;
Timer<Fullscreen> m_eventQueueTimer;
WillBeHeapDeque<RefPtrWillBeMember<Event> > m_eventQueue;
LayoutRect m_savedPlaceholderFrameRect;

Powered by Google App Engine
This is Rietveld 408576698