Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 788073004: Replace RenderFullscreen with top layer - Take II (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Updated after review comments. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 3 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 4 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 5 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 6 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 7 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 9 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
10 * Copyright (C) Research In Motion Limited 2011. All rights reserved. 10 * Copyright (C) Research In Motion Limited 2011. All rights reserved.
(...skipping 715 matching lines...) Expand 10 before | Expand all | Expand 10 after
726 // of the ancestors are first letter. 726 // of the ancestors are first letter.
727 if (pseudoId < FIRST_INTERNAL_PSEUDOID && pseudoId != FIRST_LETTER && !paren tRenderer->style()->hasPseudoStyle(pseudoId)) 727 if (pseudoId < FIRST_INTERNAL_PSEUDOID && pseudoId != FIRST_LETTER && !paren tRenderer->style()->hasPseudoStyle(pseudoId))
728 return nullptr; 728 return nullptr;
729 729
730 if (pseudoId == BACKDROP && !parent.isInTopLayer()) 730 if (pseudoId == BACKDROP && !parent.isInTopLayer())
731 return nullptr; 731 return nullptr;
732 732
733 if (pseudoId == FIRST_LETTER && (parent.isSVGElement() || !FirstLetterPseudo Element::firstLetterTextRenderer(parent))) 733 if (pseudoId == FIRST_LETTER && (parent.isSVGElement() || !FirstLetterPseudo Element::firstLetterTextRenderer(parent)))
734 return nullptr; 734 return nullptr;
735 735
736 if (!parentRenderer->canHaveGeneratedChildren()) 736 if (pseudoId != BACKDROP && !parentRenderer->canHaveGeneratedChildren())
esprehn 2015/02/20 06:23:45 The parentRenderer for BACKDROP should be the Rend
737 return nullptr; 737 return nullptr;
738 738
739 RenderStyle* parentStyle = parentRenderer->style(); 739 RenderStyle* parentStyle = parentRenderer->style();
740 if (RenderStyle* cachedStyle = parentStyle->getCachedPseudoStyle(pseudoId)) { 740 if (RenderStyle* cachedStyle = parentStyle->getCachedPseudoStyle(pseudoId)) {
741 if (!pseudoElementRendererIsNeeded(cachedStyle)) 741 if (!pseudoElementRendererIsNeeded(cachedStyle))
742 return nullptr; 742 return nullptr;
743 return createPseudoElement(&parent, pseudoId); 743 return createPseudoElement(&parent, pseudoId);
744 } 744 }
745 745
746 StyleResolverState state(document(), &parent, parentStyle); 746 StyleResolverState state(document(), &parent, parentStyle);
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
1602 visitor->trace(m_uncommonAttributeRuleSet); 1602 visitor->trace(m_uncommonAttributeRuleSet);
1603 visitor->trace(m_watchedSelectorsRules); 1603 visitor->trace(m_watchedSelectorsRules);
1604 visitor->trace(m_treeBoundaryCrossingRules); 1604 visitor->trace(m_treeBoundaryCrossingRules);
1605 visitor->trace(m_styleSharingLists); 1605 visitor->trace(m_styleSharingLists);
1606 visitor->trace(m_pendingStyleSheets); 1606 visitor->trace(m_pendingStyleSheets);
1607 visitor->trace(m_document); 1607 visitor->trace(m_document);
1608 #endif 1608 #endif
1609 } 1609 }
1610 1610
1611 } // namespace blink 1611 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698