Replace RenderFullscreen with top layer - Take II

Source/web/FullscreenController.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 150 matching lines @@
         return;
     if (WebViewClient* client = m_webViewImpl->client())
         client->exitFullScreen();
 }
 
 void FullscreenController::updateSize()
 {
     if (!isFullscreen())
         return;
 
-    RenderFullScreen* renderer = Fullscreen::from(*m_fullScreenFrame->document()).fullScreenRenderer();
-    if (renderer)
-        renderer->updateStyle();
+    Document* document = m_fullScreenFrame->document();
+    Element* fullscreenElement = Fullscreen::currentFullScreenElementFrom(*document);
+    if (fullscreenElement)
+        document->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::FullScreen));

[rune, 2014/12/15 09:39:51]

This looks like a really big cannon. Which style changes is this supposed to
trigger?

[esprehn, 2014/12/15 09:45:32]

This is probably for -webkit-full-screen-ancestor, that thing already does huge
recalcs in Element.cpp, we should fix it.

[Julien - ping for review, 2014/12/15 17:02:53]

FWIW this is copied from what Fullscreen is doing for consistency.

I would like to remove -webkit-full-screen-ancestor and
-webkit-full-screen-document but the change is already too big / disruptive so
that will wait until a follow-up patch.

[rune, 2014/12/16 14:22:14]

But in Fullscreen (and Element) setNeedsStyleRecalc is a direct consequence of
changing Element state affecting :-webkit-full-screen and
:-webkit-full-screen-ancestor selectors. In what way does updateSize() affect
selector evaluation?

 }
 
 void FullscreenController::trace(Visitor* visitor)
 {
     visitor->trace(m_provisionalFullScreenElement);
     visitor->trace(m_fullScreenFrame);
 }
 
 } // namespace blink