Replace RenderFullscreen with top layer - Take II

Source/core/dom/Document.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) Research In Motion Limited 2010-2011. All rights reserved.
@@ skipping 5076 matching lines @@
     if (!element->isInTopLayer())
         return;
     size_t position = m_topLayerElements.find(element);
     ASSERT(position != kNotFound);
     m_topLayerElements.remove(position);
     element->setIsInTopLayer(false);
 }
 
 HTMLDialogElement* Document::activeModalDialog() const
 {
-    if (m_topLayerElements.isEmpty())
-        return 0;
-    return toHTMLDialogElement(m_topLayerElements.last().get());
+    WillBeHeapVector<RefPtrWillBeMember<Element>>::const_reverse_iterator end = m_topLayerElements.rend();
+    WillBeHeapVector<RefPtrWillBeMember<Element>>::const_reverse_iterator it = m_topLayerElements.rbegin();
+    for (; it != end; ++it) {

[esprehn, 2014/12/15 09:45:32]

Use C++11 for loop.

[Julien - ping for review, 2014/12/15 17:02:53]

Done

[Julien - ping for review, 2014/12/15 21:32:03]

Actually I probably didn't do what asked for: we can't use range-based for as
it's a *reverse* iterator (it would call begin() and end() which would do a
normal iteration).

Instead I used 'auto' instead to simplify the loop.

+        Element* currentTopLayerElement = it->get();
+        if (isHTMLDialogElement(currentTopLayerElement))
+            return toHTMLDialogElement(currentTopLayerElement);
+    }
+
+    return 0;
 }
 
 void Document::exitPointerLock()
 {
     if (!page())
         return;
     if (Element* target = page()->pointerLockController().element()) {
         if (target->document() != this)
             return;
     }
@@ skipping 736 matching lines @@
 #ifndef NDEBUG
 using namespace blink;
 void showLiveDocumentInstances()
 {
     WeakDocumentSet& set = liveDocumentSet();
     fprintf(stderr, "There are %u documents currently alive:\n", set.size());
     for (Document* document : set)
         fprintf(stderr, "- Document %p URL: %s\n", document, document->url().string().utf8().data());
 }
 #endif