Followup to transfer serviceworker state during cross site navigations too.

Followup to transfer serviceworker state during cross site navigations too.
Fix a bug just introduced in https://crrev.com/bfea6ecef56cba8beb9816e8e9674a9dc456b20e.

BUG=438005
Committed: https://crrev.com/b3843e6184cf7284bc5d3c19c2c1cc5b6b487d30
Cr-Commit-Position: refs/heads/master@{#308044}

[michaeln, 2014-12-10 01:07:44]

michaeln@chromium.org changed reviewers:
+ falken@chromium.org

[michaeln, 2014-12-10 01:09:13]

ptal, the bug is that dispatcher_host() was always nulled out at the time it was
accessed during construction of the replacement.

[falken, 2014-12-10 01:20:48]

lgtm

[michaeln, 2014-12-10 01:52:10]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-12-10 01:53:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788073003/1

[michaeln, 2014-12-10 01:56:40]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-12-10 01:58:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788073003/20001

[commit-bot: I haz the power, 2014-12-10 02:57:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-10 02:57:09]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[michaeln, 2014-12-10 20:20:16]

On 2014/12/10 02:57:09, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   linux_chromium_rel_ng on tryserver.chromium.linux
>
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

bah, what did i mess up?

[michaeln, 2014-12-12 01:22:18]

https://codereview.chromium.org/788073003/diff/60001/content/browser/service_...
File content/browser/service_worker/service_worker_provider_host.cc (right):

https://codereview.chromium.org/788073003/diff/60001/content/browser/service_...
content/browser/service_worker/service_worker_provider_host.cc:264:
dispatcher_host_->Send(new ServiceWorkerMsg_DisassociateRegistration(
This is what i had messed up, not disassociating things in the renderer side.

In the context of the browser test, a new processes is not actually started, so
the 'host' gets transferred back into the same process it originally came out
of. But the renderer side asserts that there is no registration when its
handling a ServiceWorkerMsg_AssociateRegistration. That message gets sent inside
of CompleteCrossSiteTransfer and the DCHECK in the renderer was causing the test
to fail.

So we disassociate here first so that we can safely CompleteCrossSiteTransfer
even to the same process.

[michaeln, 2014-12-12 01:23:21]

The CQ bit was checked by michaeln@chromium.org

[commit-bot: I haz the power, 2014-12-12 01:25:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/788073003/60001

[commit-bot: I haz the power, 2014-12-12 03:30:55]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-12-12 03:31:50]

Patchset 4 (id:??) landed as
https://crrev.com/b3843e6184cf7284bc5d3c19c2c1cc5b6b487d30
Cr-Commit-Position: refs/heads/master@{#308044}