Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 788053007: Styling tweaks for preferences (Closed)

Created:
5 years, 11 months ago by Theresa
Modified:
5 years, 11 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Styling tweaks for preferences Make dividers full width, increase size of preference category icons to recommended minimum size for touchable items. BUG=414438 Committed: https://crrev.com/4d026c85f12efc21aefd37006b8d37be81c0cffa Cr-Commit-Position: refs/heads/master@{#310778}

Patch Set 1 #

Patch Set 2 : Add comment explaining ListView padding change #

Patch Set 3 : Restrict padding manipulation to L+ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/android/java/res/layout/preference_category.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/Preferences.java View 1 2 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Theresa
5 years, 11 months ago (2015-01-08 22:11:57 UTC) #2
newt (away)
lgtm. thanks!
5 years, 11 months ago (2015-01-08 22:18:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788053007/20001
5 years, 11 months ago (2015-01-08 22:21:28 UTC) #5
Theresa
PTAL I restricted the padding change to L+ devices. On pre-L, the listItemPadding (or whatever ...
5 years, 11 months ago (2015-01-09 01:37:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788053007/40001
5 years, 11 months ago (2015-01-09 16:01:18 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-09 16:40:55 UTC) #12
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 16:41:36 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4d026c85f12efc21aefd37006b8d37be81c0cffa
Cr-Commit-Position: refs/heads/master@{#310778}

Powered by Google App Engine
This is Rietveld 408576698