Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 788053006: Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. (Closed)

Created:
5 years, 11 months ago by hal.canary
Modified:
5 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. (patchset #6 id:140001 of https://codereview.chromium.org/821703005/) Reason for revert: A bisect proved that this change caused https://code.google.com/p/chromium/issues/detail?id=446729 Original issue's description: > Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt. > > This relands http://crrev.com/694213002 > > In the PdfMetafileSkia class, Instead of storing a > SkPDFDocument, store a vector of pages as > SkPictures. This allows access to individual at any > time. When FinishDocument() is called, use the > SkDocument API to print all pages to PDF. > > In PrintWebViewHelper::RenderPageContent, skip clipping > content to content area, since Windows printing prints > content just outside of the content area, as noted in > http://crbug.com/434079 . > > BUG=278148 > > Committed: https://crrev.com/18387e7ebb0eae6e4944e841d63ea058adab6e11 > Cr-Commit-Position: refs/heads/master@{#310032} TBR=vitalybuka@chromium.org,reed@google.com,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=278148 BUG=446729 Committed: https://crrev.com/5c2d68a04c4f5ce03f941656ad940b938dbf9f64 Cr-Commit-Position: refs/heads/master@{#310517}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -147 lines) Patch
M chrome/renderer/printing/print_web_view_helper.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 7 chunks +88 lines, -133 lines 0 comments Download
M ui/gfx/skia_util.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/gfx/skia_util.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
hal.canary
Created Revert of Remove calls to deprecated SkPDFDevice and SkPDFDocuemnt.
5 years, 11 months ago (2015-01-08 16:51:41 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788053006/1
5 years, 11 months ago (2015-01-08 16:52:57 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 11 months ago (2015-01-08 16:52:58 UTC) #4
reed1
lgtm
5 years, 11 months ago (2015-01-08 17:00:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788053006/1
5 years, 11 months ago (2015-01-08 17:02:13 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-08 17:03:52 UTC) #8
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 17:04:39 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c2d68a04c4f5ce03f941656ad940b938dbf9f64
Cr-Commit-Position: refs/heads/master@{#310517}

Powered by Google App Engine
This is Rietveld 408576698