Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 788053003: Make `RegExp.prototype.flags` getter configurable (Closed)

Created:
6 years ago by mathiasb
Modified:
6 years ago
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make `RegExp.prototype.flags` getter configurable TEST=mjsunit/harmony BUG=v8:3751 LOG=N

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M src/harmony-regexp.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/harmony/regexp-flags.js View 1 3 chunks +23 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mathiasb
PTAL. Ideas for additional tests are welcome, too.
6 years ago (2014-12-13 07:09:11 UTC) #2
Dmitry Lomov (no reviews)
lgtm
6 years ago (2014-12-13 09:00:50 UTC) #3
arv (Not doing code reviews)
LGTM
6 years ago (2014-12-13 16:09:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788053003/20001
6 years ago (2014-12-13 17:36:06 UTC) #6
commit-bot: I haz the power
6 years ago (2014-12-13 22:36:29 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001)

Powered by Google App Engine
This is Rietveld 408576698