Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 788053002: Prefer lengthOfContents over countChildren (Closed)

Created:
6 years ago by rwlbuis
Modified:
5 years, 11 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Prefer lengthOfContents over countChildren Calling lengthOfContents simplifies the code and should amount to the same thing, because lengthOfContents calls countChildren for node types that return false for offsetInCharacters. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188060

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/editing/DOMSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
rwlbuis
PTAL
6 years ago (2014-12-10 19:41:13 UTC) #2
yosin_UTC9
LGTM +yutak@ for OWNERS review
6 years ago (2014-12-11 04:39:20 UTC) #4
rwlbuis
On 2014/12/11 04:39:20, Yosi_afk_til_01_05 wrote: > LGTM > > +yutak@ for OWNERS review Ping @yutak
5 years, 11 months ago (2015-01-02 09:05:54 UTC) #5
Yuta Kitamura
lgtm
5 years, 11 months ago (2015-01-08 06:50:36 UTC) #6
rwlbuis
On 2015/01/08 06:50:36, Yuta Kitamura wrote: > lgtm Thanks!
5 years, 11 months ago (2015-01-08 15:25:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788053002/1
5 years, 11 months ago (2015-01-08 15:26:24 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-08 17:12:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188060

Powered by Google App Engine
This is Rietveld 408576698