Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: src/regexp.js

Issue 788043005: ES6 unicode escapes, part 2: Regexps. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: error reporting Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/regexp.js
diff --git a/src/regexp.js b/src/regexp.js
index e1eac76c124dbda3bc0635466617d1887fd17775..a9705cbf1eecfad4a20267bc172f19635b077c82 100644
--- a/src/regexp.js
+++ b/src/regexp.js
@@ -24,6 +24,8 @@ function DoConstructRegExp(object, pattern, flags) {
+ (pattern.multiline ? 'm' : '');
if (harmony_regexps)
flags += (pattern.sticky ? 'y' : '');
+ if (harmony_unicode)
+ flags += (pattern.unicode ? 'u' : '');
mathias 2015/01/08 12:29:07 `u` goes before `y`.
marja 2015/01/08 13:42:18 Done.
pattern = pattern.source;
}
@@ -236,6 +238,7 @@ function RegExpToString() {
if (this.ignoreCase) result += 'i';
if (this.multiline) result += 'm';
if (harmony_regexps && this.sticky) result += 'y';
+ if (harmony_unicode && this.unicode) result += 'u';
mathias 2015/01/08 12:29:07 Same here.
marja 2015/01/08 13:42:18 Done + updated mjsunit/harmony/regexp-flags.js to
return result;
}

Powered by Google App Engine
This is Rietveld 408576698