src/regexp.js - Issue 788043005: ES6 unicode escapes, part 2: Regexps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/regexp.js

Issue 788043005: ES6 unicode escapes, part 2: Regexps. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: code review (mathias, rossberg) Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/regexp.js

diff --git a/src/regexp.js b/src/regexp.js

index e1eac76c124dbda3bc0635466617d1887fd17775..9dc06c683872e47cf76774e7e2dae1665be47585 100644

--- a/src/regexp.js

+++ b/src/regexp.js

@@ -22,6 +22,8 @@ function DoConstructRegExp(object, pattern, flags) {

flags = (pattern.global ? 'g' : '')

+ (pattern.ignoreCase ? 'i' : '')

+ (pattern.multiline ? 'm' : '');

+ if (harmony_unicode)

+ flags += (pattern.unicode ? 'u' : '');

if (harmony_regexps)

flags += (pattern.sticky ? 'y' : '');

pattern = pattern.source;

@@ -236,6 +238,7 @@ function RegExpToString() {

if (this.ignoreCase) result += 'i';

if (this.multiline) result += 'm';

if (harmony_regexps && this.sticky) result += 'y';

+ if (harmony_unicode && this.unicode) result += 'u';

mathias 2015/01/08 17:12:56 Let’s move this up one line so `u` goes before `y`

marja 2015/01/09 12:11:57 Done.

return result;

}

« no previous file with comments | « src/parser.cc ('k') | src/runtime/runtime-regexp.cc » ('j') | no next file with comments »