Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 788033002: AddressSanitizer: disable ODR-violation checks on Mac (Closed)

Created:
6 years ago by hans
Modified:
6 years ago
CC:
chromium-reviews, Nico
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AddressSanitizer: disable ODR-violation checks on Mac They started failing after the Clang roll. Seems they're not ready for prime time yet. BUG=431803, 440543 TBR=glider NOTRY=true Committed: https://crrev.com/0bf822367e392d7120c1e2360cb6a8f89e24e2e6 Cr-Commit-Position: refs/heads/master@{#307565}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/sanitizers/sanitizer_options.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/788033002/1
6 years ago (2014-12-09 22:12:24 UTC) #3
Nico
lgtm
6 years ago (2014-12-09 22:14:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-09 22:18:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0bf822367e392d7120c1e2360cb6a8f89e24e2e6 Cr-Commit-Position: refs/heads/master@{#307565}
6 years ago (2014-12-09 22:18:40 UTC) #7
Alexander Potapenko
6 years ago (2014-12-10 12:48:14 UTC) #8
Message was sent while issue was closed.
On 2014/12/09 22:18:40, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/0bf822367e392d7120c1e2360cb6a8f89e24e2e6
> Cr-Commit-Position: refs/heads/master@{#307565}

Thanks!

Powered by Google App Engine
This is Rietveld 408576698