Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Unified Diff: ui/message_center/views/notifier_settings_view.cc

Issue 78803002: Fixing focus highlight on high DPI devices for accessibility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/message_center/views/notification_view.cc ('k') | ui/message_center/views/padded_button.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/message_center/views/notifier_settings_view.cc
diff --git a/ui/message_center/views/notifier_settings_view.cc b/ui/message_center/views/notifier_settings_view.cc
index 47af26016c1dc3c2a8d6da5a121a6c67e14ef83d..7446b0d9cbce49cda45561a3c55fee333cd1e106 100644
--- a/ui/message_center/views/notifier_settings_view.cc
+++ b/ui/message_center/views/notifier_settings_view.cc
@@ -21,7 +21,6 @@
#include "ui/gfx/image/image.h"
#include "ui/gfx/size.h"
#include "ui/message_center/message_center_style.h"
-#include "ui/message_center/views/message_center_focus_border.h"
#include "ui/message_center/views/message_center_view.h"
#include "ui/views/background.h"
#include "ui/views/border.h"
@@ -124,6 +123,11 @@ const int kComputedTitleTopMargin =
const int kComputedTitleElementSpacing =
settings::kDescriptionToSwitcherSpace - kButtonPainterInsets - 1;
+// A function to create a focus border.
+views::FocusBorder* CreateFocusBorder() {
+ return views::FocusBorder::CreateSolidFocusBorder(kFocusBorderColor,
+ gfx::Insets(1, 2, 3, 2));
+}
// EntryView ------------------------------------------------------------------
@@ -147,7 +151,7 @@ class EntryView : public views::View {
};
EntryView::EntryView(views::View* contents) {
- set_focus_border(new MessageCenterFocusBorder());
+ set_focus_border(CreateFocusBorder());
AddChildView(contents);
}
@@ -290,7 +294,7 @@ NotifierSettingsView::NotifierButton::NotifierButton(
if (ShouldHaveLearnMoreButton()) {
// Create a more-info button that will be right-aligned.
learn_more_ = new views::ImageButton(this);
- learn_more_->set_focus_border(new MessageCenterFocusBorder());
+ learn_more_->set_focus_border(CreateFocusBorder());
learn_more_->set_request_focus_on_press(false);
learn_more_->set_focusable(true);
« no previous file with comments | « ui/message_center/views/notification_view.cc ('k') | ui/message_center/views/padded_button.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698