Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: ui/message_center/views/message_view.cc

Issue 78803002: Fixing focus highlight on high DPI devices for accessibility (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « ui/message_center/views/message_view.h ('k') | ui/message_center/views/notification_view.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/message_center/views/message_view.h" 5 #include "ui/message_center/views/message_view.h"
6 6
7 #include "grit/ui_resources.h" 7 #include "grit/ui_resources.h"
8 #include "grit/ui_strings.h" 8 #include "grit/ui_strings.h"
9 #include "ui/base/accessibility/accessible_view_state.h" 9 #include "ui/base/accessibility/accessible_view_state.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
(...skipping 153 matching lines...) Expand 10 before | Expand all | Expand 10 after
164 PaddedButton *close = new PaddedButton(this); 164 PaddedButton *close = new PaddedButton(this);
165 close->SetPadding(-kCloseIconRightPadding, kCloseIconTopPadding); 165 close->SetPadding(-kCloseIconRightPadding, kCloseIconTopPadding);
166 close->SetNormalImage(IDR_NOTIFICATION_CLOSE); 166 close->SetNormalImage(IDR_NOTIFICATION_CLOSE);
167 close->SetHoveredImage(IDR_NOTIFICATION_CLOSE_HOVER); 167 close->SetHoveredImage(IDR_NOTIFICATION_CLOSE_HOVER);
168 close->SetPressedImage(IDR_NOTIFICATION_CLOSE_PRESSED); 168 close->SetPressedImage(IDR_NOTIFICATION_CLOSE_PRESSED);
169 close->set_owned_by_client(); 169 close->set_owned_by_client();
170 close->set_animate_on_state_change(false); 170 close->set_animate_on_state_change(false);
171 close->SetAccessibleName(l10n_util::GetStringUTF16( 171 close->SetAccessibleName(l10n_util::GetStringUTF16(
172 IDS_MESSAGE_CENTER_CLOSE_NOTIFICATION_BUTTON_ACCESSIBLE_NAME)); 172 IDS_MESSAGE_CENTER_CLOSE_NOTIFICATION_BUTTON_ACCESSIBLE_NAME));
173 close_button_.reset(close); 173 close_button_.reset(close);
174
175 set_focus_border(views::FocusBorder::CreateSolidFocusBorder(
176 kFocusBorderColor,
177 gfx::Insets(0, 1, 3, 2)));
174 } 178 }
175 179
176 MessageView::~MessageView() { 180 MessageView::~MessageView() {
177 } 181 }
178 182
179 // static 183 // static
180 gfx::Insets MessageView::GetShadowInsets() { 184 gfx::Insets MessageView::GetShadowInsets() {
181 return gfx::Insets(kShadowBlur / 2 - kShadowOffset, 185 return gfx::Insets(kShadowBlur / 2 - kShadowOffset,
182 kShadowBlur / 2, 186 kShadowBlur / 2,
183 kShadowBlur / 2 + kShadowOffset, 187 kShadowBlur / 2 + kShadowOffset,
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
252 // slide-out behavior. See http://crbug.com/172991 256 // slide-out behavior. See http://crbug.com/172991
253 257
254 if (!event->IsScrollGestureEvent() && !event->IsFlingScrollEvent()) 258 if (!event->IsScrollGestureEvent() && !event->IsFlingScrollEvent())
255 return; 259 return;
256 260
257 if (scroller_) 261 if (scroller_)
258 scroller_->OnGestureEvent(event); 262 scroller_->OnGestureEvent(event);
259 event->SetHandled(); 263 event->SetHandled();
260 } 264 }
261 265
262 void MessageView::OnPaintFocusBorder(gfx::Canvas* canvas) {
263 if (HasFocus()) {
264 canvas->DrawRect(gfx::Rect(1, 0, width() - 2, height() - 2),
265 message_center::kFocusBorderColor);
266 }
267 }
268
269 void MessageView::ButtonPressed(views::Button* sender, 266 void MessageView::ButtonPressed(views::Button* sender,
270 const ui::Event& event) { 267 const ui::Event& event) {
271 if (sender == close_button()) { 268 if (sender == close_button()) {
272 RemoveNotification(true); // By user. 269 RemoveNotification(true); // By user.
273 } 270 }
274 } 271 }
275 272
276 void MessageView::OnSlideOut() { 273 void MessageView::OnSlideOut() {
277 RemoveNotification(true); // By user. 274 RemoveNotification(true); // By user.
278 } 275 }
279 276
280 } // namespace message_center 277 } // namespace message_center
OLDNEW
« no previous file with comments | « ui/message_center/views/message_view.h ('k') | ui/message_center/views/notification_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698